Re: [U-Boot] [PATCH 1/6] Convert fw_env.c to use a single environment image union

2008-08-31 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > > This union replaces the typedef env_t, which was also defined in fw_env.c. > Thus I was not fixing the issue you describe above, which I fully agree > with - the tool and u-boot should ideally use the same definition from

Re: [U-Boot] [PATCH 1/6] Convert fw_env.c to use a single environment image union

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Use a union to cover both with and without redundant environment cases. > ... > > -typedef struct environment_s { > > - ulong crc; /* CRC32 over data by

Re: [U-Boot] [PATCH 1/6] Convert fw_env.c to use a single environment image union

2008-08-31 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > Use a union to cover both with and without redundant environment cases. ... > -typedef struct environment_s { > - ulong crc; /* CRC32 over data bytes*/ > - unsigned char flags;/* ac

[U-Boot] [PATCH 1/6] Convert fw_env.c to use a single environment image union

2008-08-27 Thread Guennadi Liakhovetski
Use a union to cover both with and without redundant environment cases. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c | 148 +--- 1 files changed, 82 insertions(+), 66 deletions(-) diff --git a/tools/env/fw_env.c