Re: [U-Boot] [PATCH 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

2015-01-05 Thread Masahiro Yamada
Hi Simon, On Sat, 27 Dec 2014 10:32:38 -0700 Simon Glass wrote: > > > > [2] It is difficult to describe alias register name for the same address. > > > > For example, > > > > #define I2C_DTTX0x04/* send FIFO */ > > #define I2C_DTRX0x04/* receive FIFO */

Re: [U-Boot] [PATCH 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

2014-12-27 Thread Simon Glass
Hi Masahiro, On 25 December 2014 at 00:15, Masahiro Yamada wrote: > Simon, Heiko, > > > If you have no objection to this series, > I will apply it to u-boot-uniphier. > > Is this OK? > > > Some replies below to Simon's comment. > > > > On Tue, 23 Dec 2014 12:54:53 -0700 > Simon Glass wrote: > >

Re: [U-Boot] [PATCH 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

2014-12-24 Thread Masahiro Yamada
Simon, Heiko, If you have no objection to this series, I will apply it to u-boot-uniphier. Is this OK? Some replies below to Simon's comment. On Tue, 23 Dec 2014 12:54:53 -0700 Simon Glass wrote: > > + > > +#define IOBUS_FREQ 1 > > + > > +struct uniphier_i2c_dev { > > +

Re: [U-Boot] [PATCH 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

2014-12-23 Thread Simon Glass
Hi Masahiro, On 22 December 2014 at 03:58, Masahiro Yamada wrote: > This commit adds on-chip I2C driver used on some old Panasonic > UniPhier SoCs. > > Signed-off-by: Masahiro Yamada >From a driver model perspective: Reviewed-by: Simon Glass A few comments below. > --- > > drivers/i2c/Kcon

[U-Boot] [PATCH 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

2014-12-22 Thread Masahiro Yamada
This commit adds on-chip I2C driver used on some old Panasonic UniPhier SoCs. Signed-off-by: Masahiro Yamada --- drivers/i2c/Kconfig| 14 +++ drivers/i2c/Makefile | 1 + drivers/i2c/i2c-uniphier.c | 225 + 3 files changed, 240 inserti