Re: [U-Boot] [PATCH 1/4] gpio: atmel: fix code to use pointer for pio port

2013-08-22 Thread Bo Shen
Hi Andreas, On 8/22/2013 14:26, Andreas Bießmann wrote: Please adopt all places in this file with mentioned changes and tell me >>your opinion about erroneous return value. > >For the erroneous return value, actually we never check it (consider it >always successfully). So, I think now we just

Re: [U-Boot] [PATCH 1/4] gpio: atmel: fix code to use pointer for pio port

2013-08-21 Thread Andreas Bießmann
Hi Bo, On 22.08.13 05:15, Bo Shen wrote: > Hi Andreas, > > On 8/21/2013 23:08, Andreas Bießmann wrote: >> Hi Bo, >> >> On 08/13/2013 08:38 AM, Bo Shen wrote: >> Please adopt all places in this file with mentioned changes and tell me >> your opinion about erroneous return value. > > For the er

Re: [U-Boot] [PATCH 1/4] gpio: atmel: fix code to use pointer for pio port

2013-08-21 Thread Bo Shen
Hi Andreas, On 8/21/2013 23:08, Andreas Bießmann wrote: Hi Bo, On 08/13/2013 08:38 AM, Bo Shen wrote: fix code to use pointer for pio port as the warning message suggested remove the warning message Signed-off-by: Bo Shen --- drivers/gpio/at91_gpio.c | 232 ++--

Re: [U-Boot] [PATCH 1/4] gpio: atmel: fix code to use pointer for pio port

2013-08-21 Thread Andreas Bießmann
Hi Bo, On 08/13/2013 08:38 AM, Bo Shen wrote: > fix code to use pointer for pio port as the warning message suggested > remove the warning message > > Signed-off-by: Bo Shen > --- > drivers/gpio/at91_gpio.c | 232 > ++ > 1 file changed, 134 insertio

[U-Boot] [PATCH 1/4] gpio: atmel: fix code to use pointer for pio port

2013-08-12 Thread Bo Shen
fix code to use pointer for pio port as the warning message suggested remove the warning message Signed-off-by: Bo Shen --- drivers/gpio/at91_gpio.c | 232 ++ 1 file changed, 134 insertions(+), 98 deletions(-) diff --git a/drivers/gpio/at91_gpio.c b/