Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Ron Madrid
> Please restrict your line length to some 70 characters. Thanks. I've been trying to take your previous advice and hit Enter every now and then, but I forgot to do so before I sent off the last email. > It should be just a single patch, unless you break it into locally > idenpendent parts,

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Wolfgang Denk
Dear Ron Madrid, In message <[EMAIL PROTECTED]> you wrote: > > I have previously read the information at the link suggested. In my mind I > felt that the Makefile on the top level and the MAKEALL and the MAINTAINERS > files would be suitable for putting together into one patch (which is what I

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Ron Madrid
> > So, I should put the patch for the top level files such as Makefile and > > MAKEALL as the last of a series of patches? That makes sense. > i > No, you should make all that belongs together one patch. > > Please see http://www.denx.de/wiki/U-Boot/Patches > I have previously read the inform

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Wolfgang Denk
Dear Ron Madrid, In message <[EMAIL PROTECTED]> you wrote: > > So, I should put the patch for the top level files such as Makefile and > MAKEALL as the last of a series of patches? That makes sense. i No, you should make all that belongs together one patch. Please see http://www.denx.de/wiki/U-

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Ron Madrid
> > > please reorder patchseries or, even better, resubmit as one single > > > patch so as to not break git bisecting. > > > > I don't understand this. Could you elaborate? > > people doing a "git bisect run" on, e.g. MAKEALL 83xx would > inadvertently run into an error because your 1/4 patch (c

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Kim Phillips
On Fri, 31 Oct 2008 13:30:22 -0700 (PDT) Ron Madrid <[EMAIL PROTECTED]> wrote: > I used git format-patch, but I did not use git send-email. I am looking into > that right now. > I didn't realize that the web email client would create such problems. And > as this is all patch submission is one

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Ron Madrid
I used git format-patch, but I did not use git send-email. I am looking into that right now. I didn't realize that the web email client would create such problems. And as this is all that I currently have access to, I am looking into using the git tools to submit the patch. > please reorder

Re: [U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Kim Phillips
On Fri, 31 Oct 2008 11:17:32 -0700 (PDT) Ron Madrid <[EMAIL PROTECTED]> wrote: > This is a patch containing changes to files on the top level for a new board > SIMPC8313. please reorder patchseries or, even better, resubmit as one single patch so as to not break git bisecting. > Signed off by:

[U-Boot] [PATCH 1/4] New Board support: Makefile MAKEALL, etc

2008-10-31 Thread Ron Madrid
This is a patch containing changes to files on the top level for a new board SIMPC8313. Signed off by: Ron Madrid <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 750e374..f844ef4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -259,6 +259,10 @@ Jon Loeliger <[EMAIL PROTECTED]>