Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2013-03-26 Thread Minkyu Kang
Dear Amar, On 27/03/13 14:18, Amarendra Reddy wrote: > Dear Minkyu, > please don't top posting. > The definition of "RX_WMARK" is present in "[PATCH V7 04/10] EXYNOS5: DWMMC: > Added FDT support for DWMMC". > > Here is the URL, > http://www.mail-archive.com/u-boot@lists.denx.de/msg107515.htm

Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2013-03-26 Thread Amarendra Reddy
Dear Minkyu, The definition of "RX_WMARK" is present in "[PATCH V7 04/10] EXYNOS5: DWMMC: Added FDT support for DWMMC". Here is the URL, http://www.mail-archive.com/u-boot@lists.denx.de/msg107515.html Thanks & Regards Amarendra Reddy On 27 March 2013 10:33, Minkyu Kang wrote: > Dear Amar, > >

Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2013-03-26 Thread Minkyu Kang
Dear Amar, On 05/12/12 22:31, Amar wrote: > The current implementation of fifo size computation was giving improper > values for eMMC channel. Modified the computation as per user manual. > > Signed-off-by: Amarendra Reddy > --- > drivers/mmc/dw_mmc.c |2 ++ > 1 files changed, 2 insertions(

Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2012-12-09 Thread Amarendra Reddy
Hi Jaehoon Chung, I will update the patches as per your review comments. As suggested by Mr.Simon, I will create macros similar to the below macros in header file. #define RX_WMARK_SHIFT 16 #define RX_WMARK_MASK (0xfff << RX_WMARK_SHIFT) Thanks & Regards Amarendra On 10 December 2012 07:51,

Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2012-12-09 Thread Jaehoon Chung
Hi Simon, On 12/09/2012 04:49 AM, Simon Glass wrote: > Hi Jaehoon, > > On Wed, Dec 5, 2012 at 7:59 PM, Jaehoon Chung wrote: >> It looks good to me. >> Added minor comment. >> >> Acked-by: Jaehoon Chung >> >> On 12/05/2012 10:31 PM, Amar wrote: >>> The current implementation of fifo size computa

Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2012-12-08 Thread Simon Glass
Hi Jaehoon, On Wed, Dec 5, 2012 at 7:59 PM, Jaehoon Chung wrote: > It looks good to me. > Added minor comment. > > Acked-by: Jaehoon Chung > > On 12/05/2012 10:31 PM, Amar wrote: >> The current implementation of fifo size computation was giving improper >> values for eMMC channel. Modified the c

Re: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2012-12-05 Thread Jaehoon Chung
It looks good to me. Added minor comment. Acked-by: Jaehoon Chung On 12/05/2012 10:31 PM, Amar wrote: > The current implementation of fifo size computation was giving improper > values for eMMC channel. Modified the computation as per user manual. > > Signed-off-by: Amarendra Reddy > --- > dr

[U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation

2012-12-05 Thread Amar
The current implementation of fifo size computation was giving improper values for eMMC channel. Modified the computation as per user manual. Signed-off-by: Amarendra Reddy --- drivers/mmc/dw_mmc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/dw_mmc.c b/d