Re: [U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

2009-10-05 Thread Ben Warren
Hi Luigi, Luigi Mantellini wrote: > Hi Ben, > > thank for your review. Find my inline comments. > > Thanks and best regards, > > luigi > > On Mon, Oct 5, 2009 at 8:27 AM, Ben Warren wrote: > >> Hi Luigi, >> >> Luigi 'Comio' Mantellini wrote: >> >>> From: Luigi 'Comio' Mantellini >>> >>>

Re: [U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

2009-10-05 Thread Luigi Mantellini
Hi Ben, thank for your review. Find my inline comments. Thanks and best regards, luigi On Mon, Oct 5, 2009 at 8:27 AM, Ben Warren wrote: > Hi Luigi, > > Luigi 'Comio' Mantellini wrote: >> >> From: Luigi 'Comio' Mantellini >> >> > > Please add some descriptive information here.  This is a big

Re: [U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

2009-10-04 Thread Ben Warren
Hi Luigi, Luigi 'Comio' Mantellini wrote: > From: Luigi 'Comio' Mantellini > > Please add some descriptive information here. This is a big patch and deserves a changelong > Signed-off-by: Luigi 'Comio' Mantellini > --- > drivers/net/phy/miiphybb.c | 324 > +++-

Re: [U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

2009-09-24 Thread Jerry Van Baren
Hi Luigi, Luigi 'Comio' Mantellini wrote: > (autoreview) > > Hi Ben, > > I make some changes to the patch, but I will post after your review. > See my annotation, that will be present into the next patch release. > > best regards. > > Il mercoledì 23 settembre 2009 15:10:54 Luigi 'Comio' Mante

Re: [U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

2009-09-24 Thread Luigi 'Comio' Mantellini
(autoreview) Hi Ben, I make some changes to the patch, but I will post after your review. See my annotation, that will be present into the next patch release. best regards. Il mercoledì 23 settembre 2009 15:10:54 Luigi 'Comio' Mantellini ha scritto: > From: Luigi 'Comio' Mantellini > > Signed

[U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

2009-09-23 Thread Luigi 'Comio' Mantellini
From: Luigi 'Comio' Mantellini Signed-off-by: Luigi 'Comio' Mantellini --- drivers/net/phy/miiphybb.c | 324 +++- include/miiphy.h | 22 +++ 2 files changed, 250 insertions(+), 96 deletions(-) diff --git a/drivers/net/phy/miiphybb.c b/driver