Re: [U-Boot] [PATCH 1/3] sysreset: switch to using SYSRESET_POWER_OFF for poweroff

2019-07-26 Thread Kever Yang
Hi Urja and Simon, Does this patch still needed? Since this patch delegate to u-boot-rockchip maintainer Philipp now, I would like to know what should I do for this patch. Thanks, - Kever Patrick DELAUNAY 于2019年5月20日周一 下午9:38写道: > Hi Urja, > > > > > Hi, > > > > On Thu, May 16, 2019 at 7:44 AM

Re: [U-Boot] [PATCH 1/3] sysreset: switch to using SYSRESET_POWER_OFF for poweroff

2019-05-20 Thread Patrick DELAUNAY
Hi Urja, > > Hi, > > On Thu, May 16, 2019 at 7:44 AM Patrick DELAUNAY > wrote: > > > > Hi Urja, > > > > > - if (type != SYSRESET_POWER) > > > + if (type != SYSRESET_POWER_OFF) > > > return -EPROTONOSUPPORT; > > > > In fact in the next part of the code, we are supporting on

Re: [U-Boot] [PATCH 1/3] sysreset: switch to using SYSRESET_POWER_OFF for poweroff

2019-05-16 Thread Urja Rannikko
Hi, On Thu, May 16, 2019 at 7:44 AM Patrick DELAUNAY wrote: > > Hi Urja, > > > - if (type != SYSRESET_POWER) > > + if (type != SYSRESET_POWER_OFF) > > return -EPROTONOSUPPORT; > > In fact in the next part of the code, we are supporting > only SYSRESET_POWER (reset with PMIC1

Re: [U-Boot] [PATCH 1/3] sysreset: switch to using SYSRESET_POWER_OFF for poweroff

2019-05-16 Thread Patrick DELAUNAY
Hi Urja, > > It seems that SYSRESET_POWER_OFF was added recently, and all previous > code used SYSRESET_POWER for poweroff. SYSRESET_POWER is supposed > to be a PMIC-level power cycle, not a poweroff. > > Signed-off-by: Urja Rannikko > --- > Note: I didnt touch the test/dm/sysreset.c code yet,

[U-Boot] [PATCH 1/3] sysreset: switch to using SYSRESET_POWER_OFF for poweroff

2019-05-13 Thread Urja Rannikko
It seems that SYSRESET_POWER_OFF was added recently, and all previous code used SYSRESET_POWER for poweroff. SYSRESET_POWER is supposed to be a PMIC-level power cycle, not a poweroff. Signed-off-by: Urja Rannikko --- Note: I didnt touch the test/dm/sysreset.c code yet, mostly because I wanted to