Re: [U-Boot] [PATCH 1/3] ppc4xx: Consolidate pci_target_init() function

2009-11-17 Thread Stefan Roese
Hi Matthias, On Sunday 15 November 2009 15:01:45 Matthias Fuchs wrote: > > +* Make this region non-prefetchable. > > +*/ > > + /* PMM0 Mask/Attribute - disabled b4 setting */ > > + out_le32((void *)PCIL0_PMM0MA, 0x); > > + /* PMM0 Local Address */ > > + out_le32((void *)PCI

Re: [U-Boot] [PATCH 1/3] ppc4xx: Consolidate pci_target_init() function

2009-11-15 Thread Matthias Fuchs
Hi Stefan, good job. Please see two comments and one question below. > This patch removes the duplicted implementations of the pci_target_init() > function by introducing a weak default function for it. This weak default > has a different implementation for 440EP(x)/GR(x) PPC's. It can be > overr