Re: [U-Boot] [PATCH 1/3] net: phy: mscc: add support for VSC8584 PHY

2018-10-31 Thread Quentin Schulz
Hi Joe, On Mon, Oct 22, 2018 at 09:52:38PM +, Joe Hershberger wrote: > On Fri, Sep 14, 2018 at 7:50 AM Quentin Schulz > wrote: [...] > > +#define MEDIA_OP_MODE_MASK 0x0700 > > Please use GENMASK() or BIT() for masks. > [...] > > +/* Extended page GPIO register 00G */ > > +#def

Re: [U-Boot] [PATCH 1/3] net: phy: mscc: add support for VSC8584 PHY

2018-10-22 Thread Joe Hershberger
On Fri, Sep 14, 2018 at 7:50 AM Quentin Schulz wrote: > > The VSC8584 PHY is a 4-port PHY that is 10/100/1000BASE-T, 100BASE-FX, > 1000BASE-X and triple-speed copper SFP capable, can communicate with the > MAC via SGMII, QSGMII or 1000BASE-X, supports downshifting and can set > the blinking patter

[U-Boot] [PATCH 1/3] net: phy: mscc: add support for VSC8584 PHY

2018-09-14 Thread Quentin Schulz
The VSC8584 PHY is a 4-port PHY that is 10/100/1000BASE-T, 100BASE-FX, 1000BASE-X and triple-speed copper SFP capable, can communicate with the MAC via SGMII, QSGMII or 1000BASE-X, supports downshifting and can set the blinking pattern of each of its 4 LEDs, supports hardware offloading of MACsec a