Re: [U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-22 Thread Tom Rini
On Fri, Dec 22, 2017 at 04:19:26PM +, York Sun wrote: > Either sending 'd' through UART, or save a variable ddr_interactive. OK, thanks, withdrawn! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-22 Thread York Sun
Either sending 'd' through UART, or save a variable ddr_interactive. York Sent from my iPhone > On Dec 22, 2017, at 08:06, Tom Rini wrote: > >> On Fri, Dec 22, 2017 at 04:02:49PM +, York Sun wrote: >> >> If SPL is used, the full driver is in SPL. It initializes DDR. It only >> makes sense

Re: [U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-22 Thread Tom Rini
On Fri, Dec 22, 2017 at 04:02:49PM +, York Sun wrote: > If SPL is used, the full driver is in SPL. It initializes DDR. It only > makes sense to have this feature there, not after relocation. We only > disable this feature is the SPL size becomes a problem. OK, but I don't understand how you c

Re: [U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-22 Thread York Sun
If SPL is used, the full driver is in SPL. It initializes DDR. It only makes sense to have this feature there, not after relocation. We only disable this feature is the SPL size becomes a problem. York Sent from my iPhone > On Dec 22, 2017, at 04:36, Tom Rini wrote: > >> On Fri, Dec 22, 2017

Re: [U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-22 Thread Tom Rini
On Fri, Dec 22, 2017 at 05:29:31AM +, York Sun wrote: > Why not? I used it before. In SPL, rather than full U-Boot? -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boo

Re: [U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-21 Thread York Sun
Why not? I used it before. York Sent from my iPhone > On Dec 21, 2017, at 19:13, Tom Rini wrote: > > While the code in question here is used in SPL, it cannot be used in > interactive mode in SPL. We need a compile-time guard here in order to > be able to not include further bits of code. >

[U-Boot] [PATCH 1/3] ddr: fsl: Do not allow for interactive mode in SPL

2017-12-21 Thread Tom Rini
While the code in question here is used in SPL, it cannot be used in interactive mode in SPL. We need a compile-time guard here in order to be able to not include further bits of code. Cc: York Sun Signed-off-by: Tom Rini --- drivers/ddr/fsl/main.c | 2 +- 1 file changed, 1 insertion(+), 1 del