Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910182055.01744.vap...@gentoo.org> you wrote: > ... > From 1ffa4c71d249e877c8b4b84e412af7efc1e8f113 Mon Sep 17 00:00:00 2001 > From: Mike Frysinger > Date: Sun, 18 Oct 2009 19:37:11 -0400 > Subject: [PATCH 2/2] env_embedded: remove unused code from linker scrip

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Mike Frysinger
On Monday 26 October 2009 08:34:35 Stefan Roese wrote: > On Monday 26 October 2009 13:26:22 Mike Frysinger wrote: > > > Thanks. With this patch, most of the ppc4xx compile problems I have > > > noticed are gone now. But unfortunately not all. Those two 4xx > > > platforms still don't compile: > > >

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Mike Frysinger
On Monday 26 October 2009 15:17:45 Wolfgang Denk wrote: > Mike Frysinger wrote: > > should be harmless, but obviously it's ugly. the attached patch should > > fix things up. the related issue is the one i raised in the other env > > embedded thread wrt the meaning of "ENV_IS_EMBEDDED" ... > > I

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910260436.12814.vap...@gentoo.org> you wrote: > > should be harmless, but obviously it's ugly. the attached patch should fix > things up. the related issue is the one i raised in the other env embedded > thread wrt the meaning of "ENV_IS_EMBEDDED" ... I see

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Stefan Roese
On Monday 26 October 2009 13:26:22 Mike Frysinger wrote: > > Thanks. With this patch, most of the ppc4xx compile problems I have > > noticed are gone now. But unfortunately not all. Those two 4xx platforms > > still don't compile: > > > > CRAYL1 EXBITGEN > > > > $ ./MAKEALL CRAYL1 > > Configuring f

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Mike Frysinger
On Monday 26 October 2009 08:13:57 Stefan Roese wrote: > On Monday 26 October 2009 09:36:11 Mike Frysinger wrote: > > > But when I remove the CONFIG_ENV_IS_EMBEDDED definition from line 127 > > > of include/configs/kilauea.h, then I get this: > > > > > > ./MAKEALL kilauea kilauea_nand > > > Con

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Stefan Roese
On Monday 26 October 2009 09:36:11 Mike Frysinger wrote: > > But when I remove the CONFIG_ENV_IS_EMBEDDED definition from line 127 > > of include/configs/kilauea.h, then I get this: > > > > ./MAKEALL kilauea kilauea_nand > > Configuring for kilauea board... > >textdata bss

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-26 Thread Mike Frysinger
On Sunday 25 October 2009 17:55:07 Wolfgang Denk wrote: > Mike Frysinger wrote: > > i'm attaching two patches here. since we're past the merge window but > > before rc1, i dont know how invasive you want to get. > > > > the first one restores env_embedded.o building for certain config options > >

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-25 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910182055.01744.vap...@gentoo.org> you wrote: > > i'm attaching two patches here. since we're past the merge window but before > rc1, i dont know how invasive you want to get. > > the first one restores env_embedded.o building for certain config options > (e

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-25 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910182055.01744.vap...@gentoo.org> you wrote: > > > This patch seems to break a *lot* of boards: > > i'm attaching two patches here. since we're past the merge window but before > rc1, i dont know how invasive you want to get. > > the first one restores env_emb

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-19 Thread Mike Frysinger
On Monday 19 October 2009 05:31:36 Wolfgang Denk wrote: > Mike Frysinger wrote: > > diff --git a/board/tqc/tqm8xx/u-boot.lds b/board/tqc/tqm8xx/u-boot.lds > > index 2df8d84..8207b2c 100644 > > --- a/board/tqc/tqm8xx/u-boot.lds > > +++ b/board/tqc/tqm8xx/u-boot.lds > > @@ -21,6 +21,8 @@ > > * MA 0

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-19 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910182055.01744.vap...@gentoo.org> you wrote: > > > This patch seems to break a *lot* of boards: > > i'm attaching two patches here. since we're past the merge window but before > rc1, i dont know how invasive you want to get. > > the first one restores env_

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Mike Frysinger
On Sunday 18 October 2009 17:32:15 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > Mike Frysinger wrote: > > > > The env code is protected by the ENV_IS_EMBEDDED define, so > > > > attempting to compile the code when this isn't defined is pointless. > > > > Now that the env headers have unified

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910181751.13743.vap...@gentoo.org> you wrote: > > i'd prefer to fix. my guess is these boards link in the .o all the time even > when they dont have an embedded environment (which isnt a big deal -- the > file > would be 0 bytes in that case). > > where can

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Mike Frysinger
On Sunday 18 October 2009 17:32:15 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > Mike Frysinger wrote: > > > > The env code is protected by the ENV_IS_EMBEDDED define, so > > > > attempting to compile the code when this isn't defined is pointless. > > > > Now that the env headers have unified

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910181701.33654.vap...@gentoo.org> you wrote: > > > Mike Frysinger wrote: > > > The env code is protected by the ENV_IS_EMBEDDED define, so attempting to > > > compile the code when this isn't defined is pointless. Now that the env > > > headers have unified ar

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910181701.33654.vap...@gentoo.org> you wrote: > > > [My understanding is that patch 2/2 will go through your BF repo now, > > right?] > > i can do that since it's already in my vendor branch Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Mike Frysinger
On Sunday 18 October 2009 16:53:54 Wolfgang Denk wrote: > Mike Frysinger wrote: > > The env code is protected by the ENV_IS_EMBEDDED define, so attempting to > > compile the code when this isn't defined is pointless. Now that the env > > headers have unified around CONFIG_ENV_IS_EMBEDDED, convert

Re: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-10-18 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1254338999-16311-1-git-send-email-vap...@gentoo.org> you wrote: > The env code is protected by the ENV_IS_EMBEDDED define, so attempting to > compile the code when this isn't defined is pointless. Now that the env > headers have unified around CONFIG_ENV_IS_EMBEDD

[U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

2009-09-30 Thread Mike Frysinger
The env code is protected by the ENV_IS_EMBEDDED define, so attempting to compile the code when this isn't defined is pointless. Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED, convert the build system to only build the env objects when this is enabled. And now that the env c