Re: [U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-27 Thread puneets
Hi, On Friday 24 February 2012 06:12 PM, Simon Glass wrote: Hi, On Thu, Feb 23, 2012 at 6:25 AM, Puneet Saxena wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena Signed-off-by: Jim Lin --- Changes for v2:

Re: [U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-24 Thread Simon Glass
Hi, On Thu, Feb 23, 2012 at 6:25 AM, Puneet Saxena wrote: > As DMA expects the buffers to be equal and larger then > cache lines, This aligns buffers at cacheline. > > Signed-off-by: Puneet Saxena > Signed-off-by: Jim Lin > --- > Changes for v2: >   - Split the commit in to 2 commits >   - "ARC

Re: [U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-24 Thread puneets
Hi Mike, On Thursday 23 February 2012 11:45 PM, Mike Frysinger wrote: * PGP Signed by an unknown key On Thursday 23 February 2012 09:25:25 Puneet Saxena wrote: --- a/common/usb_storage.c +++ b/common/usb_storage.c -static unsigned char usb_stor_buf[512]; -static ccb usb_ccb; +#ifdef ARCH_DMA_M

Re: [U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-23 Thread Mike Frysinger
On Thursday 23 February 2012 09:25:25 Puneet Saxena wrote: > --- a/common/usb_storage.c > +++ b/common/usb_storage.c > > -static unsigned char usb_stor_buf[512]; > -static ccb usb_ccb; > +#ifdef ARCH_DMA_MINALIGN > + static ccb usb_ccb __attribute__((aligned(ARCH_DMA_MINALIGN))); > +#else > +

[U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-23 Thread Puneet Saxena
As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena Signed-off-by: Jim Lin --- Changes for v2: - Split the commit in to 2 commits - "ARCH_DMA_MINALIGN" replacement - Making stop address cache line aligned by