Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Stefano Babic
Hi Fabio, Otavio, On 01/04/19 16:14, Fabio Estevam wrote: > Hi Stefano, > > On Mon, Apr 1, 2019 at 11:06 AM Stefano Babic wrote: > >> Well, it looks like too much because I have 18.04, too, and I can build. >> I cannot say that Ubuntu users cannot build u-boot anymore. >> I guess you have /bin/

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Fabio Estevam
Hi Stefano, On Mon, Apr 1, 2019 at 11:06 AM Stefano Babic wrote: > Well, it looks like too much because I have 18.04, too, and I can build. > I cannot say that Ubuntu users cannot build u-boot anymore. > I guess you have /bin/sh -> dash, and /bin/sh -> bash solves the > problem, too. Or using up

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Tom Rini
On Mon, Apr 01, 2019 at 03:46:20PM +0200, Stefano Babic wrote: > Hi Otavio, > > On 01/04/19 15:20, Otavio Salvador wrote: > > Hello everyone, > > > > On Wed, Feb 27, 2019 at 10:44 PM Fabio Estevam wrote: > >> On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach wrote: > >>> Use a single '=' to test stri

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Stefano Babic
Hi Fabio, On 01/04/19 15:49, Fabio Estevam wrote: > Hi Stefano, > > On Mon, Apr 1, 2019 at 10:46 AM Stefano Babic wrote: > >> The thing is in which conditions this is broken and why it should be >> fixed here and in this way. Yes, I admit, I have not pondered this as a >> big issue - it could b

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Otavio Salvador
On Mon, Apr 1, 2019 at 10:46 AM Stefano Babic wrote: > > This is still broken and the proposed patch does fix it. We should get > > this merged for 2019.04 release. > > > > Please Stefano, consider this for release (be it through your branch > > for directly by Tom). > > > > The thing is in which

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Fabio Estevam
Hi Stefano, On Mon, Apr 1, 2019 at 10:46 AM Stefano Babic wrote: > The thing is in which conditions this is broken and why it should be > fixed here and in this way. Yes, I admit, I have not pondered this as a > big issue - it could be also fixed replacing dash with bash on > Debian-like distros

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Stefano Babic
Hi Otavio, On 01/04/19 15:20, Otavio Salvador wrote: > Hello everyone, > > On Wed, Feb 27, 2019 at 10:44 PM Fabio Estevam wrote: >> On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach wrote: >>> Use a single '=' to test string equality for compatibility with non-bash >>> shells. Otherwise, if /bin/sh i

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-04-01 Thread Otavio Salvador
Hello everyone, On Wed, Feb 27, 2019 at 10:44 PM Fabio Estevam wrote: > On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach wrote: > > Use a single '=' to test string equality for compatibility with non-bash > > shells. Otherwise, if /bin/sh is dash, build fails: > > > > ./tools/imx8m_image.sh: 15: [: s

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-02-27 Thread Baruch Siach
Hi Fabio, On Thu, Feb 28 2019, Fabio Estevam wrote: > On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach wrote: >> >> Use a single '=' to test string equality for compatibility with non-bash >> shells. Otherwise, if /bin/sh is dash, build fails: >> >> ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-02-27 Thread Fabio Estevam
Hi Baruch and Stefano, On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach wrote: > > Use a single '=' to test string equality for compatibility with non-bash > shells. Otherwise, if /bin/sh is dash, build fails: > > ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator > ./tools/imx8

Re: [U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-01-03 Thread Christopher Spencer
On Wed, 2 Jan 2019 at 07:00, Baruch Siach wrote: > Use a single '=' to test string equality for compatibility with non-bash > shells. Otherwise, if /bin/sh is dash, build fails: > > ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator > ./tools/imx8m_image.sh: 15: [: signed_h

[U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

2019-01-01 Thread Baruch Siach
Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails: ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 1