Re: [U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-13 Thread Joe Hershberger
On Wed, Jun 13, 2018 at 3:46 AM, Rick Chen wrote: > Hi Joe and Alex > > > After trace, I found that in store_net_params( ) > if CONFIG_BOOTP_SERVERIP is not define, > net_boot_file_name will be replaced by bp->bp_file > > copy_filename(net_boot_file_name, bp->bp_file,sizeof(net_boot_file_name)); >

Re: [U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-13 Thread Rick Chen
2018-06-13 9:42 GMT+08:00 Rick Chen : > 2018-06-13 3:59 GMT+08:00 Joe Hershberger : >> On Wed, Jun 6, 2018 at 8:54 PM, Rick Chen wrote: From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, June 06, 2018 8:32 PM To: u-boot@lists.denx.de Cc: Rick Jian-Zhi Chen(陳建志); Joe H

Re: [U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-12 Thread Rick Chen
2018-06-13 3:59 GMT+08:00 Joe Hershberger : > On Wed, Jun 6, 2018 at 8:54 PM, Rick Chen wrote: >>> From: Alexander Graf [mailto:ag...@suse.de] >>> Sent: Wednesday, June 06, 2018 8:32 PM >>> To: u-boot@lists.denx.de >>> Cc: Rick Jian-Zhi Chen(陳建志); Joe Hershberger; Simon Glass >>> Subject: [PATCH 1

Re: [U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-12 Thread Joe Hershberger
On Wed, Jun 6, 2018 at 8:54 PM, Rick Chen wrote: >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Wednesday, June 06, 2018 8:32 PM >> To: u-boot@lists.denx.de >> Cc: Rick Jian-Zhi Chen(陳建志); Joe Hershberger; Simon Glass >> Subject: [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip >

Re: [U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-12 Thread Joe Hershberger
On Wed, Jun 6, 2018 at 7:32 AM, Alexander Graf wrote: > Currently we can choose between 2 different types of behavior for the > serverip variable: > > 1) Always overwrite it with the DHCP server IP address (default) > 2) Ignore what the DHCP server says (CONFIG_BOOTP_SERVERIP) > > This patch a

Re: [U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-06 Thread Rick Chen
> From: Alexander Graf [mailto:ag...@suse.de] > Sent: Wednesday, June 06, 2018 8:32 PM > To: u-boot@lists.denx.de > Cc: Rick Jian-Zhi Chen(陳建志); Joe Hershberger; Simon Glass > Subject: [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip > > Currently we can choose between 2 different types of

[U-Boot] [PATCH 1/2] net: Add option to prefer bootp/dhcp serverip

2018-06-06 Thread Alexander Graf
Currently we can choose between 2 different types of behavior for the serverip variable: 1) Always overwrite it with the DHCP server IP address (default) 2) Ignore what the DHCP server says (CONFIG_BOOTP_SERVERIP) This patch adds a 3rd option: 3) Use serverip from DHCP if no serverip is gi