Re: [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer

Wolfgang Denk wrote: > I tend to prefer my version, as it seems to be more defensive, and it > also adds an assert() for the 3rd parameter. > > If you agree, I'll apply my version? Yes, of course. Best regards, Stefano Babic -- =

Re: [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer

Dear Stefano Babic, In message <4bd81816.2050...@denx.de> you wrote: > > I have already sent a patch fixing this issue, I've seen it (unfortunately only after running into this myself). > http://lists.denx.de/pipermail/u-boot/2010-April/070347.html > > However, I preferred (easier way) to fix t

Re: [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer

Hi Stefano, On Wednesday 28 April 2010 13:12:22 Stefano Babic wrote: > > The "mtdparts add" command wrote through a NULL pointer - on many > > systems this went unnoticed (PowerPC has writable RAM there, some ARM > > systems have ROM where a write has no effect), but on arm1136 > > (i.MX31) it cra

Re: [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer

Wolfgang Denk wrote: > The "mtdparts add" command wrote through a NULL pointer - on many > systems this went unnoticed (PowerPC has writable RAM there, some ARM > systems have ROM where a write has no effect), but on arm1136 > (i.MX31) it crashed the system. > > Add appropriate checks. > Hi Wolf

[U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer

The "mtdparts add" command wrote through a NULL pointer - on many systems this went unnoticed (PowerPC has writable RAM there, some ARM systems have ROM where a write has no effect), but on arm1136 (i.MX31) it crashed the system. Add appropriate checks. Signed-off-by: Wolfgang Denk --- common/c