Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-11-04 Thread Stephen Warren
On 11/04/2012 08:32 AM, Albert ARIBAUD wrote: > Hi Stephen, > > On Sun, 28 Oct 2012 22:36:25 +0530, Vikram Narayanan > wrote: > >> On 10/28/2012 8:58 AM, Stephen Warren wrote: >>> On 10/26/2012 05:33 AM, Vikram Narayanan wrote: Some nitpicks. On 10/24/2012 10:20 AM, Stephen Warren

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-11-04 Thread Albert ARIBAUD
Hi Stephen, On Sun, 28 Oct 2012 22:36:25 +0530, Vikram Narayanan wrote: > On 10/28/2012 8:58 AM, Stephen Warren wrote: > > On 10/26/2012 05:33 AM, Vikram Narayanan wrote: > >> Some nitpicks. > >> > >> On 10/24/2012 10:20 AM, Stephen Warren wrote: > > >>> +static u8 bcm2835_sdhci_readb(struct sd

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-28 Thread Vikram Narayanan
On 10/28/2012 8:58 AM, Stephen Warren wrote: On 10/26/2012 05:33 AM, Vikram Narayanan wrote: Some nitpicks. On 10/24/2012 10:20 AM, Stephen Warren wrote: +static u8 bcm2835_sdhci_readb(struct sdhci_host *host, int reg) +{ +u32 val = bcm2835_sdhci_raw_readl(host, (reg& ~3)); +val =

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-27 Thread Stephen Warren
On 10/26/2012 05:33 AM, Vikram Narayanan wrote: > Some nitpicks. > > On 10/24/2012 10:20 AM, Stephen Warren wrote: >> This adds a simple driver for the BCM2835's SD controller. >> >> Workarounds are implemented for: >> * Register writes can't be too close to each-other in time, or they will >>

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-26 Thread Oleksandr Tymoshenko
On 10/26/2012 10:32 AM, Tom Rini wrote: On Tue, Oct 23, 2012 at 10:50:47PM -0600, Stephen Warren wrote: This adds a simple driver for the BCM2835's SD controller. Workarounds are implemented for: * Register writes can't be too close to each-other in time, or they will be lost. * Register acc

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-26 Thread Greg KH
On Fri, Oct 26, 2012 at 10:48:06AM -0700, Oleksandr Tymoshenko wrote: > On 10/26/2012 10:32 AM, Tom Rini wrote: > >On Tue, Oct 23, 2012 at 10:50:47PM -0600, Stephen Warren wrote: > >>This adds a simple driver for the BCM2835's SD controller. > >> > >>Workarounds are implemented for: > >>* Register

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-26 Thread Stephen Warren
On 10/26/2012 12:05 PM, Tom Rini wrote: > On 10/26/12 10:48, Oleksandr Tymoshenko wrote: >> On 10/26/2012 10:32 AM, Tom Rini wrote: >>> On Tue, Oct 23, 2012 at 10:50:47PM -0600, Stephen Warren >>> wrote: This adds a simple driver for the BCM2835's SD controller. Workarounds are impl

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-26 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/26/12 10:48, Oleksandr Tymoshenko wrote: > On 10/26/2012 10:32 AM, Tom Rini wrote: >> On Tue, Oct 23, 2012 at 10:50:47PM -0600, Stephen Warren wrote: >>> This adds a simple driver for the BCM2835's SD controller. >>> >>> Workarounds are implemen

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-26 Thread Tom Rini
On Tue, Oct 23, 2012 at 10:50:47PM -0600, Stephen Warren wrote: > This adds a simple driver for the BCM2835's SD controller. > > Workarounds are implemented for: > * Register writes can't be too close to each-other in time, or they will > be lost. > * Register accesses must all be 32-bit, so imp

Re: [U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-26 Thread Vikram Narayanan
Some nitpicks. On 10/24/2012 10:20 AM, Stephen Warren wrote: This adds a simple driver for the BCM2835's SD controller. Workarounds are implemented for: * Register writes can't be too close to each-other in time, or they will be lost. * Register accesses must all be 32-bit, so implement cust

[U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

2012-10-23 Thread Stephen Warren
This adds a simple driver for the BCM2835's SD controller. Workarounds are implemented for: * Register writes can't be too close to each-other in time, or they will be lost. * Register accesses must all be 32-bit, so implement custom accessors. This code was extracted from: git://github.com/gon