Re: [U-Boot] [PATCH 1/2] command/cmd_cache.c: Add optional flush arguments

2011-05-24 Thread Mike Frysinger
On Tuesday, May 24, 2011 11:06:03 McClintock Matthew-B29882 wrote: > On Mon, May 23, 2011 at 7:25 PM, Mike Frysinger wrote: > > void __weak flush_icache(void) > > { > >/* please define arch specific flush_icache */ > >puts("No arch specific flush_icache available!\n"); > > } > > T

Re: [U-Boot] [PATCH 1/2] command/cmd_cache.c: Add optional flush arguments

2011-05-24 Thread McClintock Matthew-B29882
On Mon, May 23, 2011 at 7:25 PM, Mike Frysinger wrote: > void __weak flush_icache(void) > { >        /* please define arch specific flush_icache */ >        puts("No arch specific flush_icache available!\n"); > } This syntax does not quite work for me... how about something like: void flush_icac

Re: [U-Boot] [PATCH 1/2] command/cmd_cache.c: Add optional flush arguments

2011-05-23 Thread Mike Frysinger
On Monday, May 23, 2011 14:38:52 Matthew McClintock wrote: > There are some checkpatch.pl warnings for formatting issues. In this case > I choose to keep the same formatting as was used in the file already: this is fine i think. otherwise, you'd send another patch to first fix the formatting and

[U-Boot] [PATCH 1/2] command/cmd_cache.c: Add optional flush arguments

2011-05-23 Thread Matthew McClintock
It might be desirable to have the ability to flush icache/dcache within u-boot, this patch gives each arch the ability to provide a flush_dcache/flush_icache function to let u-boot flush caches from the prompt Signed-off-by: Matthew McClintock --- There are some checkpatch.pl warnings for formatt