Re: [U-Boot] [PATCH 1/2] arm: mx6: add support for TBS2910 Matrix ARM miniPC

2014-10-22 Thread Stefano Babic
Hi Soeren, On 22/10/2014 14:16, Soeren Moch wrote: > U-Boot without video support is useless for me. So I will try to > setup the video clock correctly in a new version of this patch. ok, fine with me. > You are right here, there is no problem with setup_display() in > board_init(). > > So I w

Re: [U-Boot] [PATCH 1/2] arm: mx6: add support for TBS2910 Matrix ARM miniPC

2014-10-22 Thread Soeren Moch
Hi Stefano! On 10/22/14 10:36, Stefano Babic wrote: Hi Soeren, On 21/10/2014 19:54, Soeren Moch wrote: This is also copied from sabresd. Can we factorize in some way ? I can, and probably should, simplify this code. But in fact this code is wrong, and in the same way for many imx6q boards (

Re: [U-Boot] [PATCH 1/2] arm: mx6: add support for TBS2910 Matrix ARM miniPC

2014-10-22 Thread Stefano Babic
Hi Soeren, On 21/10/2014 19:54, Soeren Moch wrote: >> >> This is also copied from sabresd. Can we factorize in some way ? > > I can, and probably should, simplify this code. But in fact this code > is wrong, and in the same way for many imx6q boards (e.g. sabresd, > wandboard, nitrogen6x,...). T

Re: [U-Boot] [PATCH 1/2] arm: mx6: add support for TBS2910 Matrix ARM miniPC

2014-10-21 Thread Soeren Moch
Hi Stefano, Thanks for your review. +static int mx6_rgmii_rework(struct phy_device *phydev) +{ + unsigned short val; + + /* To enable AR8035 ouput a 125MHz clk from CLK_25M */ + phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7); + phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x801

Re: [U-Boot] [PATCH 1/2] arm: mx6: add support for TBS2910 Matrix ARM miniPC

2014-10-21 Thread Stefano Babic
Hi Soeren, On 18/10/2014 13:13, Soeren Moch wrote: > Add initial support for TBS2910 Matrix ARM miniPC. > Support includes MMC, Ethernet, UARTs, HDMI, USB, SATA, PCI, I2C, RTC. > > Cc: Stefano Babic > Signed-off-by: Soeren Moch > --- Just a couple of small questions: > arch/arm/Kconfig

[U-Boot] [PATCH 1/2] arm: mx6: add support for TBS2910 Matrix ARM miniPC

2014-10-18 Thread Soeren Moch
Add initial support for TBS2910 Matrix ARM miniPC. Support includes MMC, Ethernet, UARTs, HDMI, USB, SATA, PCI, I2C, RTC. Cc: Stefano Babic Signed-off-by: Soeren Moch --- arch/arm/Kconfig| 4 + board/tbs/tbs2910/Kconfig | 23 +++ board/tbs/tbs2910/Makefile | 9 + board/tbs/t