On 10:21 Fri 24 Apr , Scott Wood wrote:
> On Fri, Apr 24, 2009 at 02:57:52PM +0900, Kyungmin Park wrote:
> > Actually, I don't like the CONFIG_SYS_MONITOR_LEN approaches, now you
> > are consider the bad block at 1.
> > But we can also consider the bad block 2, if there two consecutive 2
> > ba
On Fri, Apr 24, 2009 at 02:57:52PM +0900, Kyungmin Park wrote:
> Actually, I don't like the CONFIG_SYS_MONITOR_LEN approaches, now you
> are consider the bad block at 1.
> But we can also consider the bad block 2, if there two consecutive 2
> bad block at block 1, 2, we should define the CONFIG_SYS
Hi,
On Fri, Apr 24, 2009 at 2:28 PM, AYYANARPONNUSAMY GANGHEYAMOORTHY
wrote:
> Hi Scott,
> On Apr 24, 2009 07:39 (GMT+09:00) Scott Wood wrote
>
>>>apgmoorthy wrote:
>>> This is done by the Post : [U-Boot] [PATCH 2/2] Fix OneNAND ipl to read
>>> CONFIG_SYS_MONITOR_LEN
>>>
>>> What do you feel a
Hi Kyungmin,
- Original Message -
From: "Scott Wood"
To: "apgmoorthy"
Cc: ;
Sent: Friday, April 24, 2009 4:09 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
> apgmoorthy wrote:
>> Hi Scott,
>>
>> On T
apgmoorthy wrote:
> Hi Scott,
>
> On Tuesday, March 31, 2009 4:04 AM Scott Wood Wrote :
>
>>> Note that there are a couple of board files (apollon and nmdk8815) that use
>>> the OneNAND loader
>>> that do not define CONFIG_SYS_MONITOR_LEN. I've added the maintainers to
>>> the Cc: list.
>
>
Hi Scott,
On Tuesday, March 31, 2009 4:04 AM Scott Wood Wrote :
>>Note that there are a couple of board files (apollon and nmdk8815) that use
>>the OneNAND loader
>>that do not define CONFIG_SYS_MONITOR_LEN. I've added the maintainers to the
>>Cc: list.
CONFIG_SYS_MONITOR_LEN is not define
Amit Kumar Sharma wrote:
> From Alessandro mail it is claear CONFIG_SYS_MONITOR_LEN
> only used by apollon
> that can be changed by Apollon users independently. we will
> check othe rissue of white space and release patch.
No need; I've already fixed the whitespace and applied the patch (as
not
Hi Scott,
- Original Message -
From: "Scott Wood"
To: "Alessandro Rubini"
Cc: ;
Sent: Tuesday, March 31, 2009 9:43 PM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
> Alessandro Rubini wrote:
>> Hello.
>>
>&g
Hello.
> Note that there are a couple of board files (apollon and nmdk8815) that
> use the OneNAND loader that do not define CONFIG_SYS_MONITOR_LEN. I've
> added the maintainers to the Cc: list.
Sorry for the delay.
In the nomadik board the OneNAND driver is not yet present, a few init
lines
Alessandro Rubini wrote:
> Hello.
>
>> Note that there are a couple of board files (apollon and nmdk8815) that
>> use the OneNAND loader that do not define CONFIG_SYS_MONITOR_LEN. I've
>> added the maintainers to the Cc: list.
>
> Sorry for the delay.
>
> In the nomadik board the OneNAND driv
ay, March 31, 2009 4:03 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
> apgmoorthy wrote:
>> Currently OneNAND initial program loader (ipl) reads only
>> block 0 ie 128KB.
>> However, u-boot image for apollon board is 195KB making
U-Boot image size.
>
> Signed-off-by: Rohit Hagargundgi
> Signed-off-by: Gangheyamoorthy
Applied to u-boot-nand-flash, with the below whitespace errors fixed:
Applying RE: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
.dotest/pat
Currently OneNAND initial program loader (ipl) reads only block 0 ie 128KB.
However, u-boot image for apollon board is 195KB making the board
unbootable with OneNAND.
Fix ipl to read CONFIG_SYS_MONITOR_LEN.
CONFIG_SYS_MONITOR_LEN macro holds the U-Boot image size.
Signed-off-by: Rohit Hagargundg
Hi Scott,
On Tuesday, March 24, 2009 2:55 AM , Scott Wood wrote
>> Please do find the updated patch below.
>It's easier if updated patches are sent separately from the reply (both to
>avoid getting lost,
>and to avoid having to manually strip discussion from the changelog).
>> Signed-off-by:
Hi Wolfgang,
- Original Message -
From: "Wolfgang Denk"
To: "Scott Wood"
Cc: ; "apgmoorthy"
Sent: Tuesday, March 24, 2009 4:16 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
> Dear Scott,
>
> In message <
Dear Scott,
In message <49c80b99.5010...@freescale.com> you wrote:
>
> >>> + if (page < 2 && (onenand_readw(ONENAND_SPARERAM) != 0x))
> >>> + return 1;
> >> Unnecessary parens.
> >
> > Where? I find them pretty useful.
>
> Around the second comparison. Why "if (a < b && (c != d))" a
Wolfgang Denk wrote:
> Dear Scott Wood,
>
> In message <20090323212514.ga30...@ld0162-tx32.am.freescale.net> you wrote:
>>> + /* Check for invalid block mark */
>>> + if (page < 2 && (onenand_readw(ONENAND_SPARERAM) != 0x))
>>> + return 1;
>> Unnecessary parens.
>
> Where? I fin
Dear Scott Wood,
In message <20090323212514.ga30...@ld0162-tx32.am.freescale.net> you wrote:
>
> > + /* Check for invalid block mark */
> > + if (page < 2 && (onenand_readw(ONENAND_SPARERAM) != 0x))
> > + return 1;
>
> Unnecessary parens.
Where? I find them pretty useful. Pleas
On Mon, Mar 23, 2009 at 02:32:20PM +0530, apgmoorthy wrote:
> >nblocks = (CONFIG_SYS_MONITOR_LEN + pagesize - 1) >> pageshift;
>
>- Right , But the above line dosent give the nblocks ,
> used erasesize and erase_shift.
D'oh, right.
> Please do find the updated patch below.
It's
Hi Scott,
>> +if (page < 2 && (onenand_readw(THIS_ONENAND(ONENAND_SPARERAM)) !=
>> 0x))
>Line length.
- Corrected.
>> int pagesize = ONENAND_PAGE_SIZE;
>> +int nblocks = CONFIG_SYS_MONITOR_LEN / ONENAND_BLOCK_SIZE;
>Shouldn't nblocks be rounded up?
>>
On Mon, Mar 09, 2009 at 07:45:40PM +0530, Rohit Hagargundgi wrote:
> + /* Check for invalid block mark*/
> + if (page < 2 && (onenand_readw(THIS_ONENAND(ONENAND_SPARERAM)) !=
> 0x))
> + return 1;
Line length.
> - int page, offset = 0;
> + int block = 0, page = ONE
Currently OneNAND initial program loader (ipl) reads only block 0 ie 128KB.
However, u-boot image for apollon board is 195KB making the board
unbootable with OneNAND.
Fix ipl to read CONFIG_SYS_MONITOR_LEN.
CONFIG_SYS_MONITOR_LEN macro holds the U-Boot image size.
Signed-off-by: Rohit Hagargundgi
22 matches
Mail list logo
