Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-12 Thread Tom
Alessandro Rubini wrote: >> I withdraw this patch. >> I will rethink this and come up with something better. > > I agree weak is better than ifdef. But the led situation on ARM isn't > really pleasant when you look in lib_arm/board.c . > > When I proposed a simplification of board.c back on Jul 2

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-12 Thread Alessandro Rubini
> I withdraw this patch. > I will rethink this and come up with something better. I agree weak is better than ifdef. But the led situation on ARM isn't really pleasant when you look in lib_arm/board.c . When I proposed a simplification of board.c back on Jul 22 ("[RFC] arm/board.c: avoid ifdef us

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Tom
Wolfgang Denk wrote: > Dear Tom, > > In message <4af339e1.9060...@windriver.com> you wrote: >> The arguments for using weak are getting weak :P > > :-P > >> Using weak is less relevant with the #ifdef's > > But it's the wrong direction your heading. We should get rid of > #ifdef's, not add new

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Wolfgang Denk
Dear Tom, In message <4af339e1.9060...@windriver.com> you wrote: > > The arguments for using weak are getting weak :P :-P > Using weak is less relevant with the #ifdef's But it's the wrong direction your heading. We should get rid of #ifdef's, not add new ones. With #ifdef's, you have differen

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Tom
Wolfgang Denk wrote: > Dear Tom Rix, > > In message <1257292804-10612-2-git-send-email-tom@windriver.com> you > wrote: >> The ARM board LED functions are defined as weak. >> They add a size overhead if they are not used. >> >> Now they are only defined if CONFIG_STATUS_LED is also defined. >>

Re: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-05 Thread Wolfgang Denk
Dear Tom Rix, In message <1257292804-10612-2-git-send-email-tom@windriver.com> you wrote: > The ARM board LED functions are defined as weak. > They add a size overhead if they are not used. > > Now they are only defined if CONFIG_STATUS_LED is also defined. > > The arm920t and arm926ejs _sta

[U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions

2009-11-03 Thread Tom Rix
The ARM board LED functions are defined as weak. They add a size overhead if they are not used. Now they are only defined if CONFIG_STATUS_LED is also defined. The arm920t and arm926ejs _start function calls these LED functions bl coloured_LED_init bl red_LED_on In gen