Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:22 Mon 23 Feb , Haavard Skinnemoen wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > > introduce two new weak functions board_bdinfo and cpu_bdinfo to allow > > board and cpu to print more information > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Haavard Skinnemoen >

Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-23 Thread Mike Frysinger
On Monday 23 February 2009 03:22:55 Haavard Skinnemoen wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > > introduce two new weak functions board_bdinfo and cpu_bdinfo to allow > > board and cpu to print more information > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Haavard Skin

Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-23 Thread Haavard Skinnemoen
Jean-Christophe PLAGNIOL-VILLARD wrote: > introduce two new weak functions board_bdinfo and cpu_bdinfo to allow > board and cpu to print more information > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Haavard Skinnemoen > Cc: Mike Frysinger > --- > rebase for-next > Precedent version

Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-21 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:07 Sat 21 Feb , Mike Frysinger wrote: > On Saturday 21 February 2009 03:46:20 Jean-Christophe PLAGNIOL-VILLARD wrote: > > --- a/common/cmd_bdinfo.c > > +++ b/common/cmd_bdinfo.c > > +void board_bdinfo(cmd_tbl_t *, int, int, char **) __attribute__((weak)); > > +void cpu_bdinfo(cmd_tbl_t *,

Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-21 Thread Mike Frysinger
On Saturday 21 February 2009 03:46:20 Jean-Christophe PLAGNIOL-VILLARD wrote: > --- a/common/cmd_bdinfo.c > +++ b/common/cmd_bdinfo.c > +void board_bdinfo(cmd_tbl_t *, int, int, char **) __attribute__((weak)); > +void cpu_bdinfo(cmd_tbl_t *, int, int, char **) __attribute__((weak)); since other pe

Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-21 Thread Mike Frysinger
On Saturday 21 February 2009 04:13:53 Magnus Lilja wrote: > Two minor code style comments. you dont need to quote everything up to the point where you actually comment. snipping unrelated context you arent talking about makes reading replies a lot easier. otherwise, we need to scroll over ~15

Re: [U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-21 Thread Magnus Lilja
Hi Two minor code style comments. 2009/2/21 Jean-Christophe PLAGNIOL-VILLARD : > introduce two new weak functions board_bdinfo and cpu_bdinfo to allow > board and cpu to print more information > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Haavard Skinnemoen > Cc: Mike Frysinger > -

[U-Boot] [PATCH 1/1 V3] cmd_bdinfo: move implementation to arch instead of common

2009-02-21 Thread Jean-Christophe PLAGNIOL-VILLARD
introduce two new weak functions board_bdinfo and cpu_bdinfo to allow board and cpu to print more information Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: Haavard Skinnemoen Cc: Mike Frysinger --- rebase for-next Precedent version Ack-by: Mike Frysinger Ack-by: Haavard Skinnemoen comm