Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-24 Thread Michal Simek
Ben Warren wrote: > Hi Michal, > > Michal Simek wrote: >> Hi Ben, >> >>> Hi Michal, >>> >>> Michal Simek wrote: >>> >>> >>> > All of the above mentioned issues are ones that I could easily deal > with, but one thing that really does need to change is that you > need to > use

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-24 Thread Ben Warren
Hi Michal, Michal Simek wrote: > Hi Ben, > >> Hi Michal, >> >> Michal Simek wrote: >> >> >> All of the above mentioned issues are ones that I could easily deal with, but one thing that really does need to change is that you need to use the CONFIG_NET_MULTI API. In other wo

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-24 Thread Michal Simek
Hi Ben, > Hi Michal, > > Michal Simek wrote: > > >>> All of the above mentioned issues are ones that I could easily deal >>> with, but one thing that really does need to change is that you need to >>> use the CONFIG_NET_MULTI API. In other words, your driver should have a >>> single initialize(

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-23 Thread Ben Warren
Hi Michal, Michal Simek wrote: >> All of the above mentioned issues are ones that I could easily deal >> with, but one thing that really does need to change is that you need to >> use the CONFIG_NET_MULTI API. In other words, your driver should have a >> single initialize() function (prototyped

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-23 Thread Michal Simek
Hi Ben, > Hi Michal, > > You submitted this so long ago that this driver should be in the tree > right now. Unfortunately, I didn't give a thorough enough review the > first time and I think it would be wrong to pull it in right now without > addressing some more things. If you take care of thi

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-23 Thread Michal Simek
OK. I'll look at it this week. Thanks, Michal > Hi Michal, > > You submitted this so long ago that this driver should be in the tree > right now. Unfortunately, I didn't give a thorough enough review the > first time and I think it would be wrong to pull it in right now without > addressing

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-22 Thread Ben Warren
Hi Michal, You submitted this so long ago that this driver should be in the tree right now. Unfortunately, I didn't give a thorough enough review the first time and I think it would be wrong to pull it in right now without addressing some more things. If you take care of this, I promise to pu

Re: [U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-17 Thread Michal Simek
Hi Ben, do you have any comment? If not please add it to your net repo! Thanks, Michal > From: Michal Simek > > --- > v2: Coding style cleanup, use debug() instead of printf > in debug messages > > v1: Initial version > > Signed-off-by: Michal Simek > --- > drivers/net/Makefile |

[U-Boot] [PATCH 1/1] net: Add Xilinx LL Temac driver version2

2009-02-01 Thread monstr
From: Michal Simek --- v2: Coding style cleanup, use debug() instead of printf in debug messages v1: Initial version Signed-off-by: Michal Simek --- drivers/net/Makefile |1 + drivers/net/xilinx_ll_temac.c | 540 + 2 files changed, 541 ins