Re: [U-Boot] [PATCH 1/1] common: cli: avoid memory leak

On Mon, Dec 28, 2015 at 01:12:21PM +0800, Peng Fan wrote: > Hi Simon, > On Sun, Dec 27, 2015 at 09:22:01PM -0700, Simon Glass wrote: > >Hi Peng, > > > >On 22 December 2015 at 02:14, Peng Fan wrote: > >> From: Peng Fan > >> > >> Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always > >>

Re: [U-Boot] [PATCH 1/1] common: cli: avoid memory leak

Hi Simon, On Sun, Dec 27, 2015 at 09:22:01PM -0700, Simon Glass wrote: >Hi Peng, > >On 22 December 2015 at 02:14, Peng Fan wrote: >> From: Peng Fan >> >> Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always >> check to free 'buff' to avoid memory leak. > >Are you sure? I believe need_b

Re: [U-Boot] [PATCH 1/1] common: cli: avoid memory leak

Hi Peng, On 22 December 2015 at 02:14, Peng Fan wrote: > From: Peng Fan > > Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always > check to free 'buff' to avoid memory leak. Are you sure? I believe need_buff is only true if the simple parser is being used. > > Signed-off-by: Peng Fa

[U-Boot] [PATCH 1/1] common: cli: avoid memory leak

From: Peng Fan Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always check to free 'buff' to avoid memory leak. Signed-off-by: Peng Fan Cc: Tom Rini Cc: Masahiro Yamada Cc: Simon Glass --- common/cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cli.