Re: [U-Boot] [PATCH 1/1] Make FAT code comply to coding rules.

2008-12-09 Thread Wolfgang Denk
Dear Remy, In message <[EMAIL PROTECTED]> you wrote: > > > ...but your new code has new issues, too. > > Nothing is perfect... Making this code perfect would require a > complete rewrite... ;-) ;-) > The (original) code is buggy too, because I have discovered a strange > bug which is causing m

Re: [U-Boot] [PATCH 1/1] Make FAT code comply to coding rules.

2008-12-09 Thread Remy Bohmer
Hello Wolfgang, > ...but your new code has new issues, too. Nothing is perfect... Making this code perfect would require a complete rewrite... ;-) The (original) code is buggy too, because I have discovered a strange bug which is causing me quite some headaches last week... ;-) (I have a usb stic

Re: [U-Boot] [PATCH 1/1] Make FAT code comply to coding rules.

2008-12-08 Thread Wolfgang Denk
Dear =?utf-8?q?Remy=20B=C3=B6hmer?=, In message <[EMAIL PROTECTED]> you wrote: > Currently the fat code is messy related to Coding rules. ...but your new code has new issues, too. > - if (cur_dev->block_read) { > - return cur_dev->block_read (cur_dev->dev > -

[U-Boot] [PATCH 1/1] Make FAT code comply to coding rules.

2008-12-08 Thread Remy Böhmer
Currently the fat code is messy related to Coding rules. Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> --- fs/fat/fat.c | 1004 - fs/fat/file.c | 65 ++-- include/fat.h |7 +- 3 files changed, 518 insertions(+), 558 deletions(-) dif