Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Marek Vasut
On Thursday, September 29, 2011 12:13:19 AM Scott Wood wrote: > On 09/28/2011 05:09 PM, Marek Vasut wrote: > > On Wednesday, September 28, 2011 11:57:49 PM Scott Wood wrote: > >> So I think if you need something that changes the layout from normal > >> operations, it needs to be a new mode. And it

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Scott Wood
On 09/28/2011 05:12 PM, Marek Vasut wrote: > On Wednesday, September 28, 2011 11:26:45 PM Scott Wood wrote: >> On 09/11/2011 11:06 PM, Marek Vasut wrote: >>> +static void mxs_nand_return_dma_descs(struct mxs_nand_info *info) >>> +{ >>> + int i = info->desc_index; >>> + struct mxs_dma_desc *desc

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Scott Wood
On 09/28/2011 05:09 PM, Marek Vasut wrote: > On Wednesday, September 28, 2011 11:57:49 PM Scott Wood wrote: >> So I think if you need something that changes the layout from normal >> operations, it needs to be a new mode. And it's about time to sync up >> U-Boot's NAND code with Linux again... >

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Marek Vasut
On Wednesday, September 28, 2011 11:26:45 PM Scott Wood wrote: > On 09/11/2011 11:06 PM, Marek Vasut wrote: > > +static void mxs_nand_return_dma_descs(struct mxs_nand_info *info) > > +{ > > + int i = info->desc_index; > > + struct mxs_dma_desc *desc; > > + > > + for (--i; i >= 0; i--) { > >

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Marek Vasut
On Wednesday, September 28, 2011 11:57:49 PM Scott Wood wrote: > On 09/28/2011 04:42 PM, Marek Vasut wrote: > > On Wednesday, September 28, 2011 11:26:45 PM Scott Wood wrote: > >> On 09/11/2011 11:06 PM, Marek Vasut wrote: > >>> + desc = info->desc[i]; > >>> + memset(desc, 0, sizeof

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Scott Wood
On 09/28/2011 04:42 PM, Marek Vasut wrote: > On Wednesday, September 28, 2011 11:26:45 PM Scott Wood wrote: >> On 09/11/2011 11:06 PM, Marek Vasut wrote: >>> + desc = info->desc[i]; >>> + memset(desc, 0, sizeof(struct mxs_dma_desc)); >>> + desc->address = (dma_addr_t)d

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Marek Vasut
On Wednesday, September 28, 2011 11:26:45 PM Scott Wood wrote: > On 09/11/2011 11:06 PM, Marek Vasut wrote: > > +static void mxs_nand_return_dma_descs(struct mxs_nand_info *info) > > +{ > > + int i = info->desc_index; > > + struct mxs_dma_desc *desc; > > + > > + for (--i; i >= 0; i--) { > >

Re: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-28 Thread Scott Wood
On 09/11/2011 11:06 PM, Marek Vasut wrote: > +static void mxs_nand_return_dma_descs(struct mxs_nand_info *info) > +{ > + int i = info->desc_index; > + struct mxs_dma_desc *desc; > + > + for (--i; i >= 0; i--) { This is an awkward construct. Why not just the usual: for (i = 0; i < inf

[U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver

2011-09-11 Thread Marek Vasut
Signed-off-by: Marek Vasut Cc: Scott Wood Cc: Stefano Babic Cc: Wolfgang Denk Cc: Detlev Zundel --- drivers/mtd/nand/Makefile |1 + drivers/mtd/nand/mxs_nand.c | 1159 +++ 2 files changed, 1160 insertions(+), 0 deletions(-) create mode 100644 dri