Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-13 Thread Scott Wood
On Sat, Oct 11, 2008 at 10:55:37AM +0200, Dirk Behme wrote: > >It's looking decent. I have some concerns about the ECC switching, > >though. > > Yes, I know, agreed. But changing existing kernels isn't easy, too. I meant the implementation (specifically, the re-init of things done by nand_scan_t

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-11 Thread Dirk Behme
Scott Wood wrote: On Fri, Oct 10, 2008 at 08:58:41AM +0200, Dirk Behme wrote: +/* + * omap_calculate_ecc - Generate non-inverted ECC bytes. + * + * Using noninverted ECC can be considered ugly since writing a blank + * page ie. padding will clear the ECC bytes. This is no problem as + * lon

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-10 Thread Scott Wood
On Fri, Oct 10, 2008 at 08:58:41AM +0200, Dirk Behme wrote: > >>+/* > >>+ * omap_calculate_ecc - Generate non-inverted ECC bytes. > >>+ * > >>+ * Using noninverted ECC can be considered ugly since writing a blank > >>+ * page ie. padding will clear the ECC bytes. This is no problem as > >>+ * l

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-10 Thread Dirk Behme
Wolfgang Denk wrote: > Dear Dirk Behme, > > In message <[EMAIL PROTECTED]> you wrote: > >>Changed in attachment. > > > That doesn't work. Please post patches in-line, and using a matching I know, I know ;) This is preview/RFC only while we are discussing about the final version. Sorry, forgo

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-10 Thread Wolfgang Denk
Dear Dirk Behme, In message <[EMAIL PROTECTED]> you wrote: > > Changed in attachment. That doesn't work. Please post patches in-line, and using a matching Subject: line. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Off

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-09 Thread Dirk Behme
Scott Wood wrote: [EMAIL PROTECTED] wrote: +unsigned char cs; +volatile unsigned long gpmc_cs_base_add; Make these static. gpmc_cs_base_add should be a pointer, not "unsigned long". Volatile isn't needed since you use I/O accessors, and definitely isn't needed on the address itself. Ch

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-09 Thread Scott Wood
[EMAIL PROTECTED] wrote: > +unsigned char cs; > +volatile unsigned long gpmc_cs_base_add; Make these static. gpmc_cs_base_add should be a pointer, not "unsigned long". Volatile isn't needed since you use I/O accessors, and definitely isn't needed on the address itself. > +/* > + * omap_nand_h

[U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-09 Thread dirk . behme
Subject: [PATCH 08/13 v3] ARM: OMAP3: Add NAND support From: Dirk Behme <[EMAIL PROTECTED]> Add NAND support Signed-off-by: Dirk Behme <[EMAIL PROTECTED]> --- Changes in version v3: - Fix/update NAND driver and seperate it into an own patch as proposed by Scott Wood drivers/mtd/nand/Makefi