Re: [U-Boot] [PATCH 08/08] include/configs: Better utilize CONFIG_SYS_NO_FLASH

2012-04-16 Thread Tom Rini
On 04/16/2012 01:56 PM, Wolfgang Denk wrote: Dear Tom Rini, In message<4f8c3615.9040...@ti.com> you wrote: I actually tend to believe it is a bad idea to have the #ifdef for CONFIG_SYS_NO_FLASH in And perhaps we should drop IMLS/FLASH from config_cmd_default these days? No. Rather I'd l

Re: [U-Boot] [PATCH 08/08] include/configs: Better utilize CONFIG_SYS_NO_FLASH

2012-04-16 Thread Wolfgang Denk
Dear Tom Rini, In message <4f8c3615.9040...@ti.com> you wrote: > > > I actually tend to believe it is a bad idea to have the #ifdef for > > CONFIG_SYS_NO_FLASH in > > And perhaps we should drop IMLS/FLASH from config_cmd_default these days? No. Rather I'd like to see "imls" extended to support

Re: [U-Boot] [PATCH 08/08] include/configs: Better utilize CONFIG_SYS_NO_FLASH

2012-04-16 Thread Tom Rini
On 04/13/2012 11:22 PM, Wolfgang Denk wrote: Dear Tom Rini, In message<1334355606-16491-9-git-send-email-tr...@ti.com> you wrote: In config files which it is clear when CONFIG_SYS_NO_FLASH will be set s/which it is clear when/where it is clear that/ ? (either unconditionally or based on lo

Re: [U-Boot] [PATCH 08/08] include/configs: Better utilize CONFIG_SYS_NO_FLASH

2012-04-13 Thread Wolfgang Denk
Dear Tom Rini, In message <1334355606-16491-9-git-send-email-tr...@ti.com> you wrote: > In config files which it is clear when CONFIG_SYS_NO_FLASH will be set s/which it is clear when/where it is clear that/ ? > (either unconditionally or based on logic that can happen early in the > config file

[U-Boot] [PATCH 08/08] include/configs: Better utilize CONFIG_SYS_NO_FLASH

2012-04-13 Thread Tom Rini
In config files which it is clear when CONFIG_SYS_NO_FLASH will be set (either unconditionally or based on logic that can happen early in the config file), ensure that we set that _before_ we include config_cmd_default.h so that the logic in that file will not enable CONFIG_CMD_(FLASH|IMLS). This