Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2019-02-23 Thread Peng Fan
Hi Stefano > -Original Message- > From: Peng Fan > Sent: 2019年1月29日 9:15 > To: 'Stefano Babic' > Cc: Fabio Estevam ; dl-uboot-imx > ; u-boot@lists.denx.de > Subject: RE: [PATCH 07/10] clk: imx8: add i.MX8QM clk driver > > Hi Stefano > > > > + > > > > > > > Ok - I see you decide to split

Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2019-01-28 Thread Peng Fan
> -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: 2019年1月28日 22:24 > To: Stefano Babic > Cc: Peng Fan ; Fabio Estevam > ; u-boot@lists.denx.de; dl-uboot-imx > ; Lukasz Majewski > Subject: Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.

Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2019-01-28 Thread Peng Fan
Hi Stefano > > + > > > > Ok - I see you decide to split the code on depend of the SOC type. > Nevertheless, even if defines are different, it seems to me that there is > still a > lot of common code (_imx8_clk_enable is very similar). Do we need really a > separate file for each MX8 variant ? Wh

Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2019-01-28 Thread Stefano Babic
Hi Fabio, On 28/01/19 15:23, Fabio Estevam wrote: > Hi Stefano, > > On Mon, Jan 28, 2019 at 12:04 PM Stefano Babic wrote: > >> Ok - I see you decide to split the code on depend of the SOC type. >> Nevertheless, even if defines are different, it seems to me that there >> is still a lot of common

Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2019-01-28 Thread Fabio Estevam
Hi Stefano, On Mon, Jan 28, 2019 at 12:04 PM Stefano Babic wrote: > Ok - I see you decide to split the code on depend of the SOC type. > Nevertheless, even if defines are different, it seems to me that there > is still a lot of common code (_imx8_clk_enable is very similar). Do we > need really

Re: [U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2019-01-28 Thread Stefano Babic
Hi Peng, On 24/12/18 05:04, Peng Fan wrote: > Add i.MX8QM clk driver, SDHC/FEC/UART/I2C supported. > > Signed-off-by: Peng Fan > --- > drivers/clk/imx/Makefile | 1 + > drivers/clk/imx/clk-imx8.c | 1 + > drivers/clk/imx/clk-imx8qm.c | 307 > ++

[U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

2018-12-23 Thread Peng Fan
Add i.MX8QM clk driver, SDHC/FEC/UART/I2C supported. Signed-off-by: Peng Fan --- drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-imx8.c | 1 + drivers/clk/imx/clk-imx8qm.c | 307 +++ 3 files changed, 309 insertions(+) create mode 100644 driv