Re: [U-Boot] [PATCH 06/12] marvell: comphy_a3700: fix bitmask

2016-11-16 Thread Kostya Porotchkin
Agree, both fields are 4 bits wide. Kosta -Original Message- From: Stefan Roese [mailto:s...@denx.de] Sent: Wednesday, November 16, 2016 13:32 To: Andre Przywara Cc: u-boot@lists.denx.de; Nadav Haklai; Kostya Porotchkin; Hanna Hawa Subject: Re: [PATCH 06/12] marvell: comphy_a3700: fix bi

Re: [U-Boot] [PATCH 06/12] marvell: comphy_a3700: fix bitmask

2016-11-16 Thread Stefan Roese
(Adding a few Marvell people to Cc) On 16.11.2016 01:50, Andre Przywara wrote: Obviously the mask for the rx and tx select field cannot be right, as it would overlap in one and exceed the 32-bit register in the other case. From looking at the neighbouring bits it looks like the mask should be re

[U-Boot] [PATCH 06/12] marvell: comphy_a3700: fix bitmask

2016-11-15 Thread Andre Przywara
Obviously the mask for the rx and tx select field cannot be right, as it would overlap in one and exceed the 32-bit register in the other case. From looking at the neighbouring bits it looks like the mask should be really 4 bits wide instead of 8. Pointed out by a GCC 6.2 (default) warning. Signe