Re: [U-Boot] [PATCH 05/17] sunxi: video: Improve monitor video-mode option handling

2014-12-28 Thread Hans de Goede
Hi, On 28-12-14 10:40, Ian Campbell wrote: On Wed, 2014-12-24 at 20:06 +0100, Hans de Goede wrote: +enum sunxi_monitor { + sunxi_monitor_none, + sunxi_monitor_dvi, + sunxi_monitor_hdmi, + sunxi_monitor_lcd, + sunxi_monitor_vga, +}; [...] + const char *mon_

Re: [U-Boot] [PATCH 05/17] sunxi: video: Improve monitor video-mode option handling

2014-12-28 Thread Ian Campbell
On Wed, 2014-12-24 at 20:06 +0100, Hans de Goede wrote: > +enum sunxi_monitor { > + sunxi_monitor_none, > + sunxi_monitor_dvi, > + sunxi_monitor_hdmi, > + sunxi_monitor_lcd, > + sunxi_monitor_vga, > +}; [...] > + const char *mon_desc[] = { "none", "dvi", "hdmi", "lcd", "vga

[U-Boot] [PATCH 05/17] sunxi: video: Improve monitor video-mode option handling

2014-12-24 Thread Hans de Goede
Add a sunxi_monitor enum and parse the monitor option string into this enum once, rather then doing strcmp-s on it in various places. This also adds checking for it being a valid value. This also adds new "none" and "lcd" values in preparation for lcd support. Signed-off-by: Hans de Goede --- d