Re: [U-Boot] [PATCH 03/24] mxc_i2c: create tx_byte function

2012-06-22 Thread Marek Vasut
Dear Troy Kisky, [...] > >> @@ -364,7 +340,7 @@ int i2c_read(uchar chip, uint addr, int alen, uchar > >> *buf, int len) temp |= I2CR_RSTA; > >> > >>writeb(temp, &i2c_regs->i2cr); > >> > >> - ret = i2c_imx_set_chip_addr(chip, 1); > >> + ret = tx_byte(i2c_regs, (chip << 1) | 1); > > > > Is

Re: [U-Boot] [PATCH 03/24] mxc_i2c: create tx_byte function

2012-06-22 Thread Troy Kisky
On 6/22/2012 9:58 AM, Marek Vasut wrote: Dear Troy Kisky, Use tx_byte function instead of having 3 copies of the code. Signed-off-by: Troy Kisky --- drivers/i2c/mxc_i2c.c | 72 +++-- 1 file changed, 21 insertions(+), 51 deletions(-) diff --git a

Re: [U-Boot] [PATCH 03/24] mxc_i2c: create tx_byte function

2012-06-22 Thread Marek Vasut
Dear Troy Kisky, > Use tx_byte function instead of having 3 copies > of the code. > > Signed-off-by: Troy Kisky > --- > drivers/i2c/mxc_i2c.c | 72 > +++-- 1 file changed, 21 > insertions(+), 51 deletions(-) > > diff --git a/drivers/i2c/mxc_i2c.c b/

[U-Boot] [PATCH 03/24] mxc_i2c: create tx_byte function

2012-06-21 Thread Troy Kisky
Use tx_byte function instead of having 3 copies of the code. Signed-off-by: Troy Kisky --- drivers/i2c/mxc_i2c.c | 72 +++-- 1 file changed, 21 insertions(+), 51 deletions(-) diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index 0b46c9c..