Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Tom Rini
On Mon, Aug 04, 2014 at 05:19:28PM +0300, Nikita Kiryanov wrote: > > > On 04/08/14 17:02, Tom Rini wrote: > >On Mon, Aug 04, 2014 at 04:45:57PM +0300, Nikita Kiryanov wrote: > >> > >> > >>On 04/08/14 16:10, Marek Vasut wrote: > >>>On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote:

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Marek Vasut
On Monday, August 04, 2014 at 04:11:57 PM, Nikita Kiryanov wrote: > On 04/08/14 16:51, Marek Vasut wrote: > > On Monday, August 04, 2014 at 03:45:57 PM, Nikita Kiryanov wrote: > >> On 04/08/14 16:10, Marek Vasut wrote: > >>> On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: > H

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Nikita Kiryanov
On 04/08/14 17:02, Tom Rini wrote: On Mon, Aug 04, 2014 at 04:45:57PM +0300, Nikita Kiryanov wrote: On 04/08/14 16:10, Marek Vasut wrote: On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: Hi Marek, On 03/08/14 16:46, Marek Vasut wrote: On Sunday, August 03, 2014 at 09:34:

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Nikita Kiryanov
On 04/08/14 16:51, Marek Vasut wrote: On Monday, August 04, 2014 at 03:45:57 PM, Nikita Kiryanov wrote: On 04/08/14 16:10, Marek Vasut wrote: On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: Hi Marek, On 03/08/14 16:46, Marek Vasut wrote: On Sunday, August 03, 2014 at 09:3

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Marek Vasut
On Monday, August 04, 2014 at 04:02:42 PM, Tom Rini wrote: [...] > Eeep. That seems very likely to be gotten incorrect by users. > > Can we do something like: > mxc_spi.c: > __weak int board_map_spi_cs_value(int desired_cs) { return -EINVAL; } > > fooboard.c: > board_map_spi_cs_value(int desired

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Tom Rini
On Mon, Aug 04, 2014 at 04:45:57PM +0300, Nikita Kiryanov wrote: > > > On 04/08/14 16:10, Marek Vasut wrote: > >On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: > >>Hi Marek, > >> > >>On 03/08/14 16:46, Marek Vasut wrote: > >>>On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kir

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Marek Vasut
On Monday, August 04, 2014 at 03:45:57 PM, Nikita Kiryanov wrote: > On 04/08/14 16:10, Marek Vasut wrote: > > On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: > >> Hi Marek, > >> > >> On 03/08/14 16:46, Marek Vasut wrote: > >>> On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kir

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Nikita Kiryanov
On 04/08/14 16:10, Marek Vasut wrote: On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: Hi Marek, On 03/08/14 16:46, Marek Vasut wrote: On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kiryanov wrote: MXC SPI driver has a feature whereas a GPIO line can be used as a CS sign

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Marek Vasut
On Monday, August 04, 2014 at 02:48:54 PM, Nikita Kiryanov wrote: > Hi Marek, > > On 03/08/14 16:46, Marek Vasut wrote: > > On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kiryanov wrote: > >> MXC SPI driver has a feature whereas a GPIO line can be used as a CS > >> signal. This is set up by joi

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-04 Thread Nikita Kiryanov
Hi Marek, On 03/08/14 16:46, Marek Vasut wrote: On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kiryanov wrote: MXC SPI driver has a feature whereas a GPIO line can be used as a CS signal. This is set up by joining the CS and GPIO values into a single value using (cs | gpio << 8), and passing

Re: [U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-03 Thread Marek Vasut
On Sunday, August 03, 2014 at 09:34:33 AM, Nikita Kiryanov wrote: > MXC SPI driver has a feature whereas a GPIO line can be used as a CS > signal. This is set up by joining the CS and GPIO values into a single > value using (cs | gpio << 8), and passing it off as a CS value. This > breaks the sf pr

[U-Boot] [PATCH 03/18] sf: fix sf probe

2014-08-03 Thread Nikita Kiryanov
MXC SPI driver has a feature whereas a GPIO line can be used as a CS signal. This is set up by joining the CS and GPIO values into a single value using (cs | gpio << 8), and passing it off as a CS value. This breaks the sf probe command, because it is no longer possible to invoke it as sf probe . I