Re: [U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files()

2016-05-16 Thread Tom Rini
On Mon, May 16, 2016 at 05:47:43PM +0800, Miao Yan wrote: > 2016-05-14 4:46 GMT+08:00 Tom Rini : > > On Fri, May 13, 2016 at 10:00:05PM +0800, Bin Meng wrote: > >> Hi Miao, > >> > >> On Fri, May 13, 2016 at 2:29 PM, Miao Yan wrote: > >> > This patch is part of the qfw refactor work. > >> > > >> >

Re: [U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files()

2016-05-16 Thread Miao Yan
2016-05-14 4:46 GMT+08:00 Tom Rini : > On Fri, May 13, 2016 at 10:00:05PM +0800, Bin Meng wrote: >> Hi Miao, >> >> On Fri, May 13, 2016 at 2:29 PM, Miao Yan wrote: >> > This patch is part of the qfw refactor work. >> > >> > The qemu_fwcfg_free_files() function is only used in error handling in >>

Re: [U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files()

2016-05-13 Thread Tom Rini
On Fri, May 13, 2016 at 10:00:05PM +0800, Bin Meng wrote: > Hi Miao, > > On Fri, May 13, 2016 at 2:29 PM, Miao Yan wrote: > > This patch is part of the qfw refactor work. > > > > The qemu_fwcfg_free_files() function is only used in error handling in > > ACPI table generation, let's not make this

Re: [U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files()

2016-05-13 Thread Bin Meng
Hi Miao, On Fri, May 13, 2016 at 2:29 PM, Miao Yan wrote: > This patch is part of the qfw refactor work. > > The qemu_fwcfg_free_files() function is only used in error handling in > ACPI table generation, let's not make this a core function and move it > to the right place. > But I suspect this

[U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files()

2016-05-12 Thread Miao Yan
This patch is part of the qfw refactor work. The qemu_fwcfg_free_files() function is only used in error handling in ACPI table generation, let's not make this a core function and move it to the right place. Signed-off-by: Miao Yan --- arch/x86/cpu/qemu/acpi_table.c | 13 +++-- cmd/qemu_