Re: [U-Boot] [PATCH 02/39] GCC4.6: Squash warnings in common/usb.c

2011-10-24 Thread Marek Vasut
> Dear Marek Vasut, > > In message <201110241422.30837.marek.va...@gmail.com> you wrote: > > actually the value is checked by debug_cond(). > > Consider prefixing these names with a double underscore to make more > visibale that these are internally used and not for plain mortal users > to mess w

Re: [U-Boot] [PATCH 02/39] GCC4.6: Squash warnings in common/usb.c

2011-10-24 Thread Wolfgang Denk
Dear Marek Vasut, In message <201110241422.30837.marek.va...@gmail.com> you wrote: > > actually the value is checked by debug_cond(). Consider prefixing these names with a double underscore to make more visibale that these are internally used and not for plain mortal users to mess with. Best re

Re: [U-Boot] [PATCH 02/39] GCC4.6: Squash warnings in common/usb.c

2011-10-24 Thread Marek Vasut
Hi Stefano, actually the value is checked by debug_cond(). Cheers ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 02/39] GCC4.6: Squash warnings in common/usb.c

2011-10-24 Thread Stefano Babic
On 10/22/2011 02:16 AM, Marek Vasut wrote: > usb.c: In function ‘usb_parse_config’: > usb.c:331:17: warning: variable ‘ch’ set but not used > [-Wunused-but-set-variable] > usb.c: In function ‘usb_hub_port_connect_change’: > usb.c:1123:29: warning: variable ‘portchange’ set but not used > [-Wunused-

[U-Boot] [PATCH 02/39] GCC4.6: Squash warnings in common/usb.c

2011-10-21 Thread Marek Vasut
usb.c: In function ‘usb_parse_config’: usb.c:331:17: warning: variable ‘ch’ set but not used [-Wunused-but-set-variable] usb.c: In function ‘usb_hub_port_connect_change’: usb.c:1123:29: warning: variable ‘portchange’ set but not used [-Wunused-but-set-variable] usb.c: In function ‘usb_hub_configure