Re: [U-Boot] [PATCH 02/15] sunxi_nand_spl: Drop unnecessary temp buf

2015-08-17 Thread Ian Campbell
On Mon, 2015-08-17 at 15:22 +0800, Chen-Yu Tsai wrote: > > > +#define SUNXI_DMA_DDMA_CFG_REG_DDMA_DST_DRQ_TYPE_DRAM (1 << 16) > > Might want to mention this change (correct DMA type?) in the commit > log. Yes, would be good. With that: Acked-by: Ian Campbell _

Re: [U-Boot] [PATCH 02/15] sunxi_nand_spl: Drop unnecessary temp buf

2015-08-17 Thread Chen-Yu Tsai
On Sun, Aug 16, 2015 at 4:02 AM, Hans de Goede wrote: > nand_spl_load_image() always gets called with either CONFIG_SYS_TEXT_BASE > or spl_image.load_addr as destination, both of which are properly aligened, > and have plenty of space for "overshooting" up to > CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE

[U-Boot] [PATCH 02/15] sunxi_nand_spl: Drop unnecessary temp buf

2015-08-17 Thread Hans de Goede
nand_spl_load_image() always gets called with either CONFIG_SYS_TEXT_BASE or spl_image.load_addr as destination, both of which are properly aligened, and have plenty of space for "overshooting" up to CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE bytes, as we read in CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE bytes