Re: [U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to operate nand flash

2012-07-11 Thread Zhong Hongbo
Hi Scott, On 07/10/2012 11:36 PM, Scott Wood wrote: > On 07/10/2012 08:00 AM, Zhong Hongbo wrote: >> On 07/10/2012 08:29 PM, Zhong Hongbo wrote: >>> On 07/10/2012 06:19 AM, Scott Wood wrote: On 07/07/2012 04:57 AM, Zhong Hongbo wrote: > @@ -89,15 +96,16 @@ static void s3c_nand_select_chip

Re: [U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to operate nand flash

2012-07-10 Thread Scott Wood
On 07/10/2012 08:00 AM, Zhong Hongbo wrote: > On 07/10/2012 08:29 PM, Zhong Hongbo wrote: >> On 07/10/2012 06:19 AM, Scott Wood wrote: >>> On 07/07/2012 04:57 AM, Zhong Hongbo wrote: @@ -89,15 +96,16 @@ static void s3c_nand_select_chip(struct mtd_info *mtd, int chip) */ stat

Re: [U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to operate nand flash

2012-07-10 Thread Zhong Hongbo
On 07/10/2012 08:29 PM, Zhong Hongbo wrote: > On 07/10/2012 06:19 AM, Scott Wood wrote: >> On 07/07/2012 04:57 AM, Zhong Hongbo wrote: >>> +static inline unsigned int s3c64xx_get_base_nand(void) >>> +{ >>> + return ELFIN_NAND_BASE; >>> +} >> >> unsigned long or uintptr_t would be more appropriate

Re: [U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to operate nand flash

2012-07-09 Thread Scott Wood
On 07/07/2012 04:57 AM, Zhong Hongbo wrote: > +static inline unsigned int s3c64xx_get_base_nand(void) > +{ > + return ELFIN_NAND_BASE; > +} unsigned long or uintptr_t would be more appropriate, even if U-Boot is unlikely to be 64-bit any time soon. Or better, "struct s3c64xx_nand *". > @@ -8

[U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to operate nand flash

2012-07-07 Thread Zhong Hongbo
From: Zhong Hongbo Signed-off-by: Zhong Hongbo --- arch/arm/include/asm/arch-s3c64xx/nand.h| 69 +++ arch/arm/include/asm/arch-s3c64xx/s3c6400.h | 79 ++- board/samsung/smdk6400/lowlevel_init.S |8 ++-- drivers/mtd/nand/s3c64xx.c