Re: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-11-01 Thread Tom
Mike Frysinger wrote: > On Sunday 01 November 2009 09:02:22 Tom wrote: >> Mike Frysinger wrote: >>> On Saturday 31 October 2009 22:00:09 Tom wrote: Mike Frysinger wrote: > On Saturday 31 October 2009 13:37:39 Tom Rix wrote: >> +#ifdef DEBUG >> +static inline void print_device_descr

Re: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-11-01 Thread Mike Frysinger
On Sunday 01 November 2009 09:02:22 Tom wrote: > Mike Frysinger wrote: > > On Saturday 31 October 2009 22:00:09 Tom wrote: > >> Mike Frysinger wrote: > >>> On Saturday 31 October 2009 13:37:39 Tom Rix wrote: > +#ifdef DEBUG > +static inline void print_device_descriptor(struct > usb_d

Re: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-11-01 Thread Tom
Mike Frysinger wrote: > On Saturday 31 October 2009 22:00:09 Tom wrote: >> Mike Frysinger wrote: >>> On Saturday 31 October 2009 13:37:39 Tom Rix wrote: +#ifdef DEBUG +static inline void print_device_descriptor(struct usb_device_descriptor *d) +{ + serial_printf("usb device de

Re: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-11-01 Thread Mike Frysinger
On Saturday 31 October 2009 22:00:09 Tom wrote: > Mike Frysinger wrote: > > On Saturday 31 October 2009 13:37:39 Tom Rix wrote: > >> +#ifdef DEBUG > >> +static inline void print_device_descriptor(struct usb_device_descriptor > >> *d) +{ > >> + serial_printf("usb device descriptor \n"); > > > > do

Re: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-10-31 Thread Tom
Mike Frysinger wrote: > On Saturday 31 October 2009 13:37:39 Tom Rix wrote: >> +#ifdef DEBUG >> +static inline void print_device_descriptor(struct usb_device_descriptor >> *d) +{ >> +serial_printf("usb device descriptor \n"); > > do you really need serial_printf() ? what's wrong with debug()

Re: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-10-31 Thread Mike Frysinger
On Saturday 31 October 2009 13:37:39 Tom Rix wrote: > +#ifdef DEBUG > +static inline void print_device_descriptor(struct usb_device_descriptor > *d) +{ > + serial_printf("usb device descriptor \n"); do you really need serial_printf() ? what's wrong with debug() ? then you dont even really

[U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.

2009-10-31 Thread Tom Rix
When developing usb device features, it is useful to print out common usb structures. Signed-off-by: Tom Rix --- include/usbdescriptors.h | 26 include/usbdevice.h | 103 ++ 2 files changed, 129 insertions(+), 0 deletions(-) diff