Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Mon 17 Aug 2009 16:20, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908171555.31016.rg...@blackfin.uclinux.org> you wrote: > > > > > Why static int? This gives a random init value for the second and each > > > following TFTP transfers. > > > > Nope - it is set to zero on the s

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Wolfgang Denk
Dear Robin Getz, In message <200908171555.31016.rg...@blackfin.uclinux.org> you wrote: > > > Why static int? This gives a random init value for the second and each > > following TFTP transfers. > > Nope - it is set to zero on the start of every transfer. Right, I saw this later, at the end of yo

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Mon 17 Aug 2009 15:05, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908171315.40365.rg...@blackfin.uclinux.org> you wrote: > > > > Comments welcome... > > I guess the code is largely untested? I tested it on a single machine. > > diff --git a/net/tftp.c b/net/tftp.c > > inde

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Wolfgang Denk
Dear Robin Getz, In message <200908171321.44317.rg...@blackfin.uclinux.org> you wrote: > > Also wondering -- if the user sets the "tftpblocksize" to a number larger > than IP_MAXUDP, the transfer will never finish. Should this be restricted > here? Sounds like a good idea to me. Best regards, W

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Wolfgang Denk
Dear Robin Getz, In message <200908171315.40365.rg...@blackfin.uclinux.org> you wrote: > > Comments welcome... I guess the code is largely untested? > diff --git a/net/tftp.c b/net/tftp.c > index 9544691..56db247 100644 > --- a/net/tftp.c > +++ b/net/tftp.c > @@ -66,6 +66,9 @@ static ulong

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Sat 8 Aug 2009 05:50, Ben Warren pondered: > Allesandro, > > Alessandro Rubini wrote: > > I finally fixed the defrag code, testing with NFS as well. > > Didn't take performance figures, tough, for lack of time. > > > > I wanted to do "config + environment" for the NFS case, like tftp, but > > d

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Thu 13 Aug 2009 18:01, Wolfgang Denk pondered: > Dear Robin Getz, > In message <200908131747.20194.rg...@blackfin.uclinux.org> you wrote: > > The better thing to do (IMHO) - would be to print out the proper number of > > hashes, depending on the size of the file (and implement RFC 2349 at the

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-13 Thread Wolfgang Denk
Dear Robin Getz, In message <200908131747.20194.rg...@blackfin.uclinux.org> you wrote: > > > I have to admit that I am no friend of this puts_quiet() thingy. > > How much time do we really save on a normal system? > > A small fraction. Thanks for measuring it. > As the network gets faster, and

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-13 Thread Robin Getz
On Wed 12 Aug 2009 17:30, Wolfgang Denk pondered: > Dear Ben Warren, > > In message <4a832bce.9060...@gmail.com> you wrote: > > > > Sure, if you don't mind re-compiling. I think it might be an > > opt-outable message via puts_quiet() > > It seems we start having a mess here, with features bound

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-13 Thread Robin Getz
On Wed 12 Aug 2009 16:04, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908121148.16431.rg...@blackfin.uclinux.org> you wrote: > > > > Some info for the docs, when I was troubleshooting a Ubuntu 9.04 > install. > > Good info, but bad format. Can you please submit this as a patch?

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Wolfgang Denk
Dear Ben Warren, In message <4a832bce.9060...@gmail.com> you wrote: > > Sure, if you don't mind re-compiling. I think it might be an > opt-outable message via puts_quiet() It seems we start having a mess here, with features bound to other features that have not even been agreeds about yet. I h

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Ben Warren
Robin Getz wrote: > On Wed 12 Aug 2009 16:05, Ben Warren pondered: > >> Hi Robin, >> >> Robin Getz wrote: >> >>> On Mon 10 Aug 2009 15:57, Ben Warren pondered: >>> >>> Robin Getz wrote: > Thanks to Alessandro for putting it together. > > Fe

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Robin Getz
On Wed 12 Aug 2009 16:05, Ben Warren pondered: > Hi Robin, > > Robin Getz wrote: > > On Mon 10 Aug 2009 15:57, Ben Warren pondered: > > > >> Robin Getz wrote: > >> > >>> Thanks to Alessandro for putting it together. > >>> > >>> Feel free to add my Signed-off (once the docs have been update

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Ben Warren
Hi Robin, Robin Getz wrote: > On Mon 10 Aug 2009 15:57, Ben Warren pondered: > >> Robin Getz wrote: >> >>> Thanks to Alessandro for putting it together. >>> >>> Feel free to add my Signed-off (once the docs have been updated >>> explaining what this is all for). >>> >>> >>> >> I'

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Wolfgang Denk
Dear Robin Getz, In message <200908121148.16431.rg...@blackfin.uclinux.org> you wrote: > > Some info for the docs, when I was troubleshooting a Ubuntu 9.04 install. Good info, but bad format. Can you please submit this as a patch? Thanks in advance. Best regards, Wolfgang Denk -- DENX Softwa

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Robin Getz
On Mon 10 Aug 2009 15:57, Ben Warren pondered: > Robin Getz wrote: > > Thanks to Alessandro for putting it together. > > > > Feel free to add my Signed-off (once the docs have been updated > > explaining what this is all for). > > > > > I'll do that. Thanks for all your help. Some info for the

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-10 Thread Wolfgang Denk
Dear Robin Getz, In message <200908101551.52052.rg...@blackfin.uclinux.org> you wrote: > > Checking out performance with tftp - server is Linux 2.6.27 located in > Germany, client (U-Boot running net/next) is located in the USA. Packets > fragmented, and arriving out of order. ... > So, that is

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-10 Thread Ben Warren
Robin Getz wrote: > On Sat 8 Aug 2009 05:50, Ben Warren pondered: > >> Allesandro, >> >> Alessandro Rubini wrote: >> >>> I finally fixed the defrag code, testing with NFS as well. >>> Didn't take performance figures, tough, for lack of time. >>> > > Checking out performance with tftp

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-10 Thread Robin Getz
On Sat 8 Aug 2009 05:50, Ben Warren pondered: > Allesandro, > > Alessandro Rubini wrote: > > I finally fixed the defrag code, testing with NFS as well. > > Didn't take performance figures, tough, for lack of time. Checking out performance with tftp - server is Linux 2.6.27 located in Germany, cl

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-08 Thread Ben Warren
Allesandro, Alessandro Rubini wrote: > I finally fixed the defrag code, testing with NFS as well. > Didn't take performance figures, tough, for lack of time. > > I wanted to do "config + environment" for the NFS case, like tftp, but > didnt' do the second step out of laziness (also, the source fil

[U-Boot] [PATCH 0/4] Network defrag

2009-08-07 Thread Alessandro Rubini
I finally fixed the defrag code, testing with NFS as well. Didn't take performance figures, tough, for lack of time. I wanted to do "config + environment" for the NFS case, like tftp, but didnt' do the second step out of laziness (also, the source file has long lines while I have 80 columns). For