Dear Sanjeev,
in message you
wrote:
>
> Also, I believe faster execution time is always better; not just
> in critical sections of code. I possibly used "global" quite loosely;
> while responding earlier. The variable cpu_revision (being discussed)
> here is actually a 'static'. (See patch 1/2).
Premi, Sanjeev wrote:
>> -Original Message-
>> From: Paulraj, Sandeep
>> Sent: Thursday, January 07, 2010 9:02 PM
>> To: Premi, Sanjeev; u-boot@lists.denx.de
>> Subject: RE: [PATCH 0/2] omap3: Optimize detection of cpu revision
-Original Message-
From: Premi, Sanjeev
> -Original Message-
> From: Paulraj, Sandeep
> Sent: Thursday, January 07, 2010 9:02 PM
> To: Premi, Sanjeev; u-boot@lists.denx.de
> Subject: RE: [PATCH 0/2] omap3: Optimize detection of cpu revision
> >
> > > -Original Message-
> > > From: Premi, Sanjeev
> > > Sent: Tuesday, Dec
> -Original Message-
> From: Paulraj, Sandeep
> Sent: Thursday, January 07, 2010 9:02 PM
> To: Premi, Sanjeev; u-boot@lists.denx.de
> Subject: RE: [PATCH 0/2] omap3: Optimize detection of cpu revision
>
>
> >
> > > -Original Message-
> > > From: Premi, Sanjeev
> > > Sent: Tuesda
>
> > -Original Message-
> > From: Premi, Sanjeev
> > Sent: Tuesday, December 15, 2009 6:48 PM
> > To: u-boot@lists.denx.de
> > Cc: Premi, Sanjeev
> > Subject: [PATCH 0/2] omap3: Optimize detection of cpu revision
> >
> > Each call to get_cpu_rev() leads to repetitive
> > execution of cod
> -Original Message-
> From: Premi, Sanjeev
> Sent: Tuesday, December 15, 2009 6:48 PM
> To: u-boot@lists.denx.de
> Cc: Premi, Sanjeev
> Subject: [PATCH 0/2] omap3: Optimize detection of cpu revision
>
> Each call to get_cpu_rev() leads to repetitive
> execution of code to detect the cpu
Dear "Premi, Sanjeev",
In message you
wrote:
>
> Also, I don't believe there is any complexity added as
> the contents of register are being read and saved in a
> global variable for use later.
Global variables are a bad thing if there is not really a good reason
to hav ethem. Here it makes no
> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Tuesday, December 15, 2009 10:44 PM
> To: Premi, Sanjeev
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection
> of cpu revision
>
> Sanjeev Pr
Sanjeev Premi wrote:
> Each call to get_cpu_rev() leads to repetitive
> execution of code to detect the cpu revision.
>
> This patchset ensures that mechanism to detect
> revision is not executed each time; instead a
> stored value is returned.
>
> Since, revision info is needed in s_init(),
> th
Each call to get_cpu_rev() leads to repetitive
execution of code to detect the cpu revision.
This patchset ensures that mechanism to detect
revision is not executed each time; instead a
stored value is returned.
Since, revision info is needed in s_init(),
the function to identify cpu revision nee
10 matches
Mail list logo
