Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Boris Brezillon
On Tue, 4 Dec 2018 11:33:13 +0100 Boris Brezillon wrote: > > > > i. e. this is a feature of the shell and not of any command. > > Implementing this a zillion times for each of the commands in > > inacceptable. Also, implementing it for one command and not for > > another makese no sense - that

Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Boris Brezillon
On Tue, 04 Dec 2018 14:00:47 +0100 Wolfgang Denk wrote: > Dear Boris, > > In message <20181204113313.577178ac@bbrezillon> you wrote: > > > > > But is this not based on the code of mtd_name_complete() which is > > > only availabole when MTD is present? > > > > Nope. See patch 1, the code is c

Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Wolfgang Denk
Dear Boris, In message <20181204113313.577178ac@bbrezillon> you wrote: > > > But is this not based on the code of mtd_name_complete() which is > > only availabole when MTD is present? > > Nope. See patch 1, the code is completely independent from the mtd cmd. OK, then I misread the patches. > Ap

Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Boris Brezillon
Hi Wolfgang, On Tue, 04 Dec 2018 11:14:31 +0100 Wolfgang Denk wrote: > Dear Boris, > > In message <20181204105448.63b9af8c@bbrezillon> you wrote: > > > > > > It's pretty common to pass arguments that start with a $ and are then > > > > expanded by the shell, and I'm this kind of lazy guy that

Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Wolfgang Denk
Dear Boris, In message <20181204105448.63b9af8c@bbrezillon> you wrote: > > > > It's pretty common to pass arguments that start with a $ and are then > > > expanded by the shell, and I'm this kind of lazy guy that hits tab all > > > the time and expects the shell to suggest something appropriate. S

Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Boris Brezillon
On Tue, 04 Dec 2018 10:44:19 +0100 Wolfgang Denk wrote: > Dear Boris, > > In message <20181203220726.19370-1-boris.brezil...@bootlin.com> you wrote: > > > > It's pretty common to pass arguments that start with a $ and are then > > expanded by the shell, and I'm this kind of lazy guy that hits t

Re: [U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-04 Thread Wolfgang Denk
Dear Boris, In message <20181203220726.19370-1-boris.brezil...@bootlin.com> you wrote: > > It's pretty common to pass arguments that start with a $ and are then > expanded by the shell, and I'm this kind of lazy guy that hits tab all > the time and expects the shell to suggest something appropria

[U-Boot] [PATCH 0/2] cmd: auto-complete args starting with a $

2018-12-03 Thread Boris Brezillon
Hello, It's pretty common to pass arguments that start with a $ and are then expanded by the shell, and I'm this kind of lazy guy that hits tab all the time and expects the shell to suggest something appropriate. So here is a patchset adding support for ${} auto-completion and using the new helper