Re: [U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:16 Tue 04 Nov , [EMAIL PROTECTED] wrote: > Subject: [PATCH-OMAP3] OMAP3: Plain numbers don't need parens > > From: Dirk Behme <[EMAIL PROTECTED]> > > Use a consistent style. Plain numbers don't need parens. Proposed by Wolfgang > Denk. > > Signed-off-by: Dirk Behme <[EMAIL PROTECTED]>

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-04 Thread Graeme Russ
On Wed, Nov 5, 2008 at 6:12 AM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > Dear Dirk, > > In message <[EMAIL PROTECTED]> you wrote: >> >> Use a consistent style. Plain numbers don't need parens. Proposed by >> Wolfgang Denk. >> >> Signed-off-by: Dirk Behme <[EMAIL PROTECTED]> > ... > > But... > >>

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-04 Thread Wolfgang Denk
Dear Magnus, In message <[EMAIL PROTECTED]> you wrote: > > > you might comment that such a #define is dangerous in itself, but why > > not protet against it? with a number we are sure we don't need parens, > > but with a macro we'd should rather play safe. > > Should we really start protection a

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-04 Thread Magnus Lilja
Dear Wolfgang, 2008/11/4 Wolfgang Denk <[EMAIL PROTECTED]>: > Dear Dirk, > > In message <[EMAIL PROTECTED]> you wrote: >> >> Use a consistent style. Plain numbers don't need parens. Proposed by >> Wolfgang Denk. >> >> Signed-off-by: Dirk Behme <[EMAIL PROTECTED]> > ... > > But... > >> /* GPMC CS

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-04 Thread Dirk Behme
Wolfgang Denk wrote: > Dear Dirk, > > In message <[EMAIL PROTECTED]> you wrote: > >>Use a consistent style. Plain numbers don't need parens. Proposed by Wolfgang >>Denk. >> >>Signed-off-by: Dirk Behme <[EMAIL PROTECTED]> > > ... > > But... > > >> /* GPMC CS3/cs4/cs6 not avaliable */ >>-#defi

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-04 Thread Wolfgang Denk
Dear Dirk, In message <[EMAIL PROTECTED]> you wrote: > > Use a consistent style. Plain numbers don't need parens. Proposed by Wolfgang > Denk. > > Signed-off-by: Dirk Behme <[EMAIL PROTECTED]> ... But... > /* GPMC CS3/cs4/cs6 not avaliable */ > -#define GPMC_BASE(OMAP34XX_GPMC_BA

[U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

2008-11-04 Thread dirk . behme
Subject: [PATCH-OMAP3] OMAP3: Plain numbers don't need parens From: Dirk Behme <[EMAIL PROTECTED]> Use a consistent style. Plain numbers don't need parens. Proposed by Wolfgang Denk. Signed-off-by: Dirk Behme <[EMAIL PROTECTED]> --- include/asm-arm/arch-omap3/cpu.h | 66 +++