Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-10-08 Thread Simon Glass
Hi Lokesh, On 27 September 2017 at 00:27, Lokesh Vutla wrote: > > > On Monday 25 September 2017 07:45 AM, Simon Glass wrote: >> Hi, >> >> On 16 September 2017 at 23:12, Lokesh Vutla wrote: >>> Simon, >>> >>> On 9/16/2017 9:43 PM, Simon Glass wrote: Hi, On 16 September 2017 at 07:4

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-26 Thread Lokesh Vutla
On Monday 25 September 2017 07:45 AM, Simon Glass wrote: > Hi, > > On 16 September 2017 at 23:12, Lokesh Vutla wrote: >> Simon, >> >> On 9/16/2017 9:43 PM, Simon Glass wrote: >>> Hi, >>> >>> On 16 September 2017 at 07:43, Tom Rini wrote: On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vu

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-24 Thread Simon Glass
Hi, On 16 September 2017 at 23:12, Lokesh Vutla wrote: > Simon, > > On 9/16/2017 9:43 PM, Simon Glass wrote: >> Hi, >> >> On 16 September 2017 at 07:43, Tom Rini wrote: >>> On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout lo

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Lokesh Vutla
Simon, On 9/16/2017 9:43 PM, Simon Glass wrote: > Hi, > > On 16 September 2017 at 07:43, Tom Rini wrote: >> On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: >>> Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") >>> fixes the loop delay when using a hw watchdog. Bu

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Simon Glass
Hi, On 16 September 2017 at 07:43, Tom Rini wrote: > On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: >> Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") >> fixes the loop delay when using a hw watchdog. But assuming that Watchdog >> kicking is taken care of by ge

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Tom Rini
On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: > Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") > fixes the loop delay when using a hw watchdog. But assuming that Watchdog > kicking is taken care of by getc(). This is not true in case of DM_SERIAL. > So, kick th

[U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Lokesh Vutla
Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") fixes the loop delay when using a hw watchdog. But assuming that Watchdog kicking is taken care of by getc(). This is not true in case of DM_SERIAL. So, kick the watchdog before loop waiting, instead of relying on other functions.