Re: [U-Boot] [PATCH] x86: turn off cache: set control register properly

2011-10-15 Thread Graeme Russ
On 01/10/11 04:27, Ondrej Kupka wrote: > Bits should be ORed when they are supposed to be added together > > Cc: Graeme Russ > Signed-off-by: Ondrej Kupka > --- > arch/x86/cpu/start16.S |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Applied to u-boot-x86 Thanks, Graeme

Re: [U-Boot] [PATCH] x86: turn off cache: set control register properly

2011-09-30 Thread Marek Vasut
On Friday, September 30, 2011 10:56:03 PM Ondra Kupka wrote: > Dear Marek, > > I am not really sure it would bring any advantage since it is used only on > 2 places as far as I know and the meaning of those few lines of code is > very clear and commented... > > Regards, > Ondra K. Dear Ondrej Ku

Re: [U-Boot] [PATCH] x86: turn off cache: set control register properly

2011-09-30 Thread Ondra Kupka
Dear Marek, I am not really sure it would bring any advantage since it is used only on 2 places as far as I know and the meaning of those few lines of code is very clear and commented... Regards, Ondra K. On Fri, Sep 30, 2011 at 10:24 PM, Marek Vasut wrote: > On Friday, September 30, 2011 08:2

Re: [U-Boot] [PATCH] x86: turn off cache: set control register properly

2011-09-30 Thread Marek Vasut
On Friday, September 30, 2011 08:27:07 PM Ondrej Kupka wrote: > Bits should be ORed when they are supposed to be added together > > Cc: Graeme Russ > Signed-off-by: Ondrej Kupka > --- > arch/x86/cpu/start16.S |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x

[U-Boot] [PATCH] x86: turn off cache: set control register properly

2011-09-30 Thread Ondrej Kupka
Bits should be ORed when they are supposed to be added together Cc: Graeme Russ Signed-off-by: Ondrej Kupka --- arch/x86/cpu/start16.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S index 3d3017a..9dabff2 100644 --- a/ar