Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-10-13 Thread Remy Bohmer
Hi, 2010/10/11 Mike Frysinger : > On Friday, August 13, 2010 06:25:05 Sergei Shtylyov wrote: >> Remy Bohmer wrote: >> > Sergei, do you agree that I apply this patch? >> >>     Well, if it's based on the Linux code... although it still does look >> wrong... I don't know. :-) > > do you have a board

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-10-11 Thread Mike Frysinger
On Friday, August 13, 2010 06:25:05 Sergei Shtylyov wrote: > Remy Bohmer wrote: > > Sergei, do you agree that I apply this patch? > > Well, if it's based on the Linux code... although it still does look > wrong... I don't know. :-) do you have a board you could test on ? otherwise, it seems

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-13 Thread Sergei Shtylyov
Hello. Remy Bohmer wrote: >>> Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c } else { - if (!toggle) - writew(MUSB_RXCSR_CLRDATATOG, &musbr->rxcsr); - else { +

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Mike Frysinger
On Thu, Aug 12, 2010 at 2:04 PM, Remy Bohmer wrote: > 2010/8/10 Mike Frysinger: >> On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote: >>> Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c        } else { -               if (!toggle) >

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Mike Frysinger
On Thu, Aug 12, 2010 at 2:08 PM, Remy Bohmer wrote: > 2010/8/9 Mike Frysinger: >> From: Bryan Wu >> >> This is a change similar to what is already in the Linux driver.  We >> should only program the CLRDATATOG bit when the current mode indicates >> that it is needed. >> >> Signed-off-by: Bryan Wu

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Remy Bohmer
Hi Mike, 2010/8/9 Mike Frysinger : > From: Bryan Wu > > This is a change similar to what is already in the Linux driver.  We > should only program the CLRDATATOG bit when the current mode indicates > that it is needed. > > Signed-off-by: Bryan Wu You use a email adress here that gets bounced du

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/10 Mike Frysinger : > On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote: >> Mike Frysinger wrote: >>> --- a/drivers/usb/musb/musb_hcd.c >>> +++ b/drivers/usb/musb/musb_hcd.c >>>        } else { >>> -               if (!toggle) >>> -                       writew(MUSB_RXCSR_CLRDATATO

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-10 Thread Mike Frysinger
On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote: > Mike Frysinger wrote: >> --- a/drivers/usb/musb/musb_hcd.c >> +++ b/drivers/usb/musb/musb_hcd.c >>        } else { >> -               if (!toggle) >> -                       writew(MUSB_RXCSR_CLRDATATOG, &musbr->rxcsr); >> -               el

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-10 Thread Sergei Shtylyov
Hello. Mike Frysinger wrote: > From: Bryan Wu > This is a change similar to what is already in the Linux driver. We > should only program the CLRDATATOG bit when the current mode indicates > that it is needed. > Signed-off-by: Bryan Wu > Signed-off-by: Cliff Cai > Signed-off-by: Mike Frysin

[U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-09 Thread Mike Frysinger
From: Bryan Wu This is a change similar to what is already in the Linux driver. We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by: Bryan Wu Signed-off-by: Cliff Cai Signed-off-by: Mike Frysinger --- Note: can someone give this a spin o