Re: [U-Boot] [PATCH] usb: kbd: Don't fail with iomux

2017-10-08 Thread Simon Glass
+Tom On 26 September 2017 at 19:19, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add ourselves

Re: [U-Boot] [PATCH] usb: kbd: Don't fail with iomux

2017-10-05 Thread Bin Meng
On Wed, Sep 27, 2017 at 9:19 AM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add ourselves to t

Re: [U-Boot] [PATCH] usb: kbd: Don't fail with iomux

2017-10-05 Thread Peter Robinson
On Wed, Sep 27, 2017 at 2:19 AM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add ourselves to t

[U-Boot] [PATCH] usb: kbd: Don't fail with iomux

2017-09-26 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. This fixes an issue with usbkbd

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 13 August 2017 at 12:07, Rob Clark wrote: > On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: >> Hi Rob, >> >> On 6 August 2017 at 05:58, Rob Clark wrote: >>> >>> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >>> > On 4 August 2017 at 07:16, Bin Meng wrote: >>> >> Hi Rob, >

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: > Hi Rob, > > On 6 August 2017 at 05:58, Rob Clark wrote: >> >> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> > On 4 August 2017 at 07:16, Bin Meng wrote: >> >> Hi Rob, >> >> >> >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >>

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 6 August 2017 at 05:58, Rob Clark wrote: > > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > > On 4 August 2017 at 07:16, Bin Meng wrote: > >> Hi Rob, > >> > >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: > >>> stdin might not be set, which would cause iomux_doenv() to fai

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-06 Thread Rob Clark
On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > On 4 August 2017 at 07:16, Bin Meng wrote: >> Hi Rob, >> >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >>> stdin might not be set, which would cause iomux_doenv() to fail >>> therefore causing probe_usb_keyboard() to fail. Furthermore i

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-06 Thread Bin Meng
Hi Rob, On Sun, Aug 6, 2017 at 6:41 PM, Rob Clark wrote: > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> On 4 August 2017 at 07:16, Bin Meng wrote: >>> Hi Rob, >>> >>> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: stdin might not be set, which would cause iomux_doenv() to fail

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-06 Thread Rob Clark
On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > On 4 August 2017 at 07:16, Bin Meng wrote: >> Hi Rob, >> >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >>> stdin might not be set, which would cause iomux_doenv() to fail >>> therefore causing probe_usb_keyboard() to fail. Furthermore i

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-05 Thread Simon Glass
On 4 August 2017 at 07:16, Bin Meng wrote: > Hi Rob, > > On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >> stdin might not be set, which would cause iomux_doenv() to fail >> therefore causing probe_usb_keyboard() to fail. Furthermore if we do >> have iomux enabled, the sensible thing (in terms

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-04 Thread Bin Meng
Hi Rob, On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add oursel

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-04 Thread Bin Meng
Hi Rob, On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: > On Fri, Aug 4, 2017 at 8:35 AM, Bin Meng wrote: >> Hi Rob, >> >> On Fri, Aug 4, 2017 at 7:52 PM, Rob Clark wrote: >>> stdin might not be set, which would cause iomux_doenv() to fail >>> therefore causing probe_usb_keyboard() to fail. F

[U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-04 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. This fixes an issue with usbkbd

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-04 Thread Rob Clark
On Fri, Aug 4, 2017 at 8:35 AM, Bin Meng wrote: > Hi Rob, > > On Fri, Aug 4, 2017 at 7:52 PM, Rob Clark wrote: >> stdin might not be set, which would cause iomux_doenv() to fail >> therefore causing probe_usb_keyboard() to fail. Furthermore if we do >> have iomux enabled, the sensible thing (in

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-04 Thread Bin Meng
Hi Rob, On Fri, Aug 4, 2017 at 7:52 PM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add oursel

[U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-04 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. This fixes an issue with usbkbd

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-03 Thread Bin Meng
On Fri, Aug 4, 2017 at 3:22 AM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add ourselves to th

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-03 Thread Rob Clark
On Thu, Aug 3, 2017 at 3:37 PM, Simon Glass wrote: > Hi Rob, > > On 3 August 2017 at 13:22, Rob Clark wrote: >> stdin might not be set, which would cause iomux_doenv() to fail >> therefore causing probe_usb_keyboard() to fail. Furthermore if we do >> have iomux enabled, the sensible thing (in te

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-03 Thread Simon Glass
Hi Rob, On 3 August 2017 at 13:22, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add ourselves t

[U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-08-03 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. This fixes an issue with usbkbd

[U-Boot] [PATCH] usb: kbd: don't fail with iomux

2017-07-03 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. Signed-off-by: Rob Clark --- c