Dear Albert ARIBAUD,
> Hi Marek,
>
> On Sat, 1 Sep 2012 17:12:29 +0200, Marek Vasut wrote:
> > > > > One place where lumping and misalignement prevention did clash
> > > > > was raised in the previous discussion: a 7+1 bytes
> > > > > function-local char array was allocated on a non-aligned
> >
Dear Albert ARIBAUD,
In message <20120901182841.3ae8b35f@lilith> you wrote:
>
> Each architecture has its own capabilites regarding native misaligned
> accesses... This is why I consider that as a general rule U-Boot should
> always align its data properly, because (hopefully) all architectures
>
Hi Marek,
On Sat, 1 Sep 2012 17:12:29 +0200, Marek Vasut wrote:
> > > > One place where lumping and misalignement prevention did clash
> > > > was raised in the previous discussion: a 7+1 bytes
> > > > function-local char array was allocated on a non-aligned
> > > > address (which is possible an
Dear Albert ARIBAUD,
> Hi Marek,
>
> On Sat, 1 Sep 2012 16:34:09 +0200, Marek Vasut wrote:
> > Dear Albert ARIBAUD,
> >
> > > Hi Marek,
> > >
> > > On Sat, 1 Sep 2012 00:16:43 +0200, Marek Vasut
> > >
> > > wrote:
> > > > Dear Albert ARIBAUD,
> > > >
> > > > > I think you are talking about
Dear Albert ARIBAUD,
> Hi Marek,
>
> On Sat, 1 Sep 2012 00:16:43 +0200, Marek Vasut wrote:
> > Dear Albert ARIBAUD,
> >
> > > I think you are talking about lumping small-sized accesses together
> > > into a bigger access possibly aligned.
> >
> > This is exactly what I mean.
> >
> > > If I am
Hi Marek,
(Apologies for the private mail)
On Sat, 1 Sep 2012 00:16:43 +0200, Marek Vasut wrote:
> Dear Albert ARIBAUD,
> > I think you are talking about lumping small-sized accesses together
> > into a bigger access possibly aligned.
>
> This is exactly what I mean.
>
> > If I am correct, t
Dear Albert ARIBAUD,
> Hi Marek,
>
> On Fri, 31 Aug 2012 18:15:30 +0200, Marek Vasut wrote:
> > Dear Albert ARIBAUD,
> >
> > > Hi Marek,
> > >
> > > On Fri, 31 Aug 2012 01:29:05 +0200, Marek Vasut
> > >
> > > wrote:
> > > > Dear Lucas Stach,
> > > >
> > > > > usb_hub_descriptor has to be pa
Dear Albert ARIBAUD,
> Hi Marek,
>
> On Fri, 31 Aug 2012 01:29:05 +0200, Marek Vasut wrote:
> > Dear Lucas Stach,
> >
> > > usb_hub_descriptor has to be packed as it's used for
> > > communication with the device. Member wHubCharacteristics
> > > violates the natural alignment rules.
> > >
> >
Hi Thomas,
Am Freitag, den 31.08.2012, 08:57 + schrieb Langer Thomas (LQDE RD
ST PON SW):
> Hello Lucas,
>
> > @@ -304,8 +306,9 @@ static int usb_hub_configure(struct usb_device *dev)
> > }
> > memcpy((unsigned char *)&hub->desc, buffer, descriptor->bLength);
> > /* adjust 16bit v
Hi Marek,
On Fri, 31 Aug 2012 01:29:05 +0200, Marek Vasut wrote:
> Dear Lucas Stach,
>
> > usb_hub_descriptor has to be packed as it's used for
> > communication with the device. Member wHubCharacteristics
> > violates the natural alignment rules.
> >
> > Use explicit unaligned access function
Dear Lucas Stach,
> usb_hub_descriptor has to be packed as it's used for
> communication with the device. Member wHubCharacteristics
> violates the natural alignment rules.
>
> Use explicit unaligned access functions for this member.
> Fixes ARMv7 traping while using USB.
Shouldn't a properly co
usb_hub_descriptor has to be packed as it's used for
communication with the device. Member wHubCharacteristics
violates the natural alignment rules.
Use explicit unaligned access functions for this member.
Fixes ARMv7 traping while using USB.
Signed-off-by: Lucas Stach
---
common/usb_hub.c
12 matches
Mail list logo
