Re: [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place

2016-01-15 Thread Simon Glass
On 8 January 2016 at 05:04, Marek Vasut wrote: > On Friday, January 08, 2016 at 04:34:44 AM, Simon Glass wrote: >> Hi Marek, >> >> On 7 January 2016 at 15:50, Marek Vasut wrote: >> > On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote: >> >> We can define this in the header file and u

Re: [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place

2016-01-08 Thread Marek Vasut
On Friday, January 08, 2016 at 04:34:44 AM, Simon Glass wrote: > Hi Marek, > > On 7 January 2016 at 15:50, Marek Vasut wrote: > > On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote: > >> We can define this in the header file and use it in usb_storage.c. There > >> is no need to defin

Re: [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place

2016-01-07 Thread Simon Glass
Hi Marek, On 7 January 2016 at 15:50, Marek Vasut wrote: > On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote: >> We can define this in the header file and use it in usb_storage.c. There is >> no need to define it twice. Remove the #define from usb_storage.c. >> >> Signed-off-by: Sim

Re: [U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place

2016-01-07 Thread Marek Vasut
On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote: > We can define this in the header file and use it in usb_storage.c. There is > no need to define it twice. Remove the #define from usb_storage.c. > > Signed-off-by: Simon Glass I guess you build tested this properly, right ? Revi

[U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place

2016-01-07 Thread Simon Glass
We can define this in the header file and use it in usb_storage.c. There is no need to define it twice. Remove the #define from usb_storage.c. Signed-off-by: Simon Glass --- common/usb_storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/usb_storage.c b/common/usb_storage.c index