Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

Hi Jana, On 11/12/11 03:09, Jana Rapava wrote: > > > 2011/11/8 Igor Grinberg > > > > > +/* > > + * This is a family of wrapper functions which sets bits in ULPI > registers. > > + * Access mode could be WRITE, SET or CLEAR. > > What about READ

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

2011/11/8 Igor Grinberg > > > +/* > > + * This is a family of wrapper functions which sets bits in ULPI > registers. > > + * Access mode could be WRITE, SET or CLEAR. > > What about READ? > I know it can be done from any of those registers, but it is confusing. > > > + * For further informations

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

Hi Jana, Thanks for porting this. Several comments below. On 11/05/11 22:50, Jana Rapava wrote: > Add generic functions for ULPI init and setting bits in > ULPI registers. > > Signed-off-by: Jana Rapava > Cc: Marek Vasut > Cc: Remy Bohmer > Cc: Stefano Babic > Cc: Igor Grinberg > --- > M

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

On 11/06/11 01:32, Jana Rapava wrote: > > > 2011/11/6 Marek Vasut mailto:marek.va...@gmail.com>> > > > 2011/11/5 Marek Vasut > > > > > > > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 ulpi_mask) > > > > > > So this works only with

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

> 2011/11/6 Marek Vasut > > > > 2011/11/5 Marek Vasut > > > > > > > > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 > > > > > ulpi_mask) > > > > > > > > So this works only with EHCI? How generic is it then ? > > > > > > I thought until now that ULPI is EHCI-dependent, but isn't...

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

2011/11/6 Marek Vasut > > 2011/11/5 Marek Vasut > > > > > > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 ulpi_mask) > > > > > > So this works only with EHCI? How generic is it then ? > > > > I thought until now that ULPI is EHCI-dependent, but isn't... Ok, what > else > > should be

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

> 2011/11/5 Marek Vasut > > > > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 ulpi_mask) > > > > So this works only with EHCI? How generic is it then ? > > I thought until now that ULPI is EHCI-dependent, but isn't... Ok, what else > should be supported? OHCI? I haven't any hardware

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

2011/11/5 Marek Vasut > > > +int ulpi_wait(struct usb_ehci *ehci, u32 ulpi_value, u32 ulpi_mask) > > So this works only with EHCI? How generic is it then ? > > I thought until now that ULPI is EHCI-dependent, but isn't... Ok, what else should be supported? OHCI? I haven't any hardware to test it,

Re: [U-Boot] [PATCH] ulpi: add generic ULPI functionality

> Add generic functions for ULPI init and setting bits in > ULPI registers. > > Signed-off-by: Jana Rapava > Cc: Marek Vasut > Cc: Remy Bohmer > Cc: Stefano Babic > Cc: Igor Grinberg > --- > Makefile |1 + > drivers/usb/ulpi/Makefile| 44 ++ >

[U-Boot] [PATCH] ulpi: add generic ULPI functionality

Add generic functions for ULPI init and setting bits in ULPI registers. Signed-off-by: Jana Rapava Cc: Marek Vasut Cc: Remy Bohmer Cc: Stefano Babic Cc: Igor Grinberg --- Makefile |1 + drivers/usb/ulpi/Makefile| 44 ++ drivers/usb/ulpi/ulp