Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-12-06 Thread Wolfgang Denk
Dear Igor Grinberg, In message <1322467058-30532-1-git-send-email-grinb...@compulab.co.il> you wrote: > When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, > the environment.h file does not get included resulting in unrecognized > env_t type. > Fix this by moving the include directiv

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-12-05 Thread Igor Grinberg
ping! This fixes a compile breakage and IMO should be applied before 2011.12 is out. Can someone, please apply it? On 11/28/11 09:57, Igor Grinberg wrote: > When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, > the environment.h file does not get included resulting in unrecognized >

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Igor Grinberg
On 11/29/11 06:25, Mike Frysinger wrote: > On Monday 28 November 2011 02:57:38 Igor Grinberg wrote: >> When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, >> the environment.h file does not get included resulting in unrecognized >> env_t type. >> Fix this by moving the include directiv

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Igor Grinberg
On 11/28/11 17:15, Wolfgang Denk wrote: > Dear Igor Grinberg, > > In message <4ed34e9b.7040...@compulab.co.il> you wrote: >> >>> Hm... the fix seems wrong to me. What happens now if ENV_IS_EMBEDDED >>> is set, but CONFIG_BUILD_ENVCRC is _not_ set? >> >> Well, you should look into that file... >

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Igor Grinberg
On 11/28/11 20:52, Mike Frysinger wrote: > On Mon, Nov 28, 2011 at 04:04, Igor Grinberg wrote: >> I don't have the tool chain for ppc. > > http://dev.gentoo.org/~vapier/u-boot/ 10x Mike -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de h

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Mike Frysinger
On Monday 28 November 2011 02:57:38 Igor Grinberg wrote: > When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, > the environment.h file does not get included resulting in unrecognized > env_t type. > Fix this by moving the include directive. seems to work for me now; thanks! Tested-by

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Mike Frysinger
On Mon, Nov 28, 2011 at 04:04, Igor Grinberg wrote: > I don't have the tool chain for ppc. http://dev.gentoo.org/~vapier/u-boot/ -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Wolfgang Denk
Dear Igor Grinberg, In message <4ed34e9b.7040...@compulab.co.il> you wrote: > > > Hm... the fix seems wrong to me. What happens now if ENV_IS_EMBEDDED > > is set, but CONFIG_BUILD_ENVCRC is _not_ set? > > Well, you should look into that file... It's faster for me to ask you to do that :-) > >

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Igor Grinberg
Hi Wolfgang, On 11/28/11 10:07, Wolfgang Denk wrote: > Dear Igor Grinberg, > > In message <1322467058-30532-1-git-send-email-grinb...@compulab.co.il> you > wrote: >> When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, >> the environment.h file does not get included resulting in unre

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Igor Grinberg
Hi Wolfgang, On 11/28/11 10:18, Wolfgang Denk wrote: > Dear Igor Grinberg, > > In message <1322467058-30532-1-git-send-email-grinb...@compulab.co.il> you > wrote: >> When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, >> the environment.h file does not get included resulting in unre

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Wolfgang Denk
Dear Igor Grinberg, In message <1322467058-30532-1-git-send-email-grinb...@compulab.co.il> you wrote: > When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, > the environment.h file does not get included resulting in unrecognized > env_t type. > Fix this by moving the include directiv

Re: [U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-28 Thread Wolfgang Denk
Dear Igor Grinberg, In message <1322467058-30532-1-git-send-email-grinb...@compulab.co.il> you wrote: > When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, > the environment.h file does not get included resulting in unrecognized > env_t type. > Fix this by moving the include directiv

[U-Boot] [PATCH] tools/envcrc: fix compile breakage

2011-11-27 Thread Igor Grinberg
When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, the environment.h file does not get included resulting in unrecognized env_t type. Fix this by moving the include directive. Reported-by: Mike Frysinger Signed-off-by: Igor Grinberg --- tools/envcrc.c |6 +++--- 1 files change