Re: [U-Boot] [PATCH] tools/env: fix redundant env flag comparison

2011-04-20 Thread Wolfgang Denk
Dear Jon Povey, In message <1299820256-29757-1-git-send-email-jon.po...@racelogic.co.uk> you wrote: > This fixes two bugs with comparison of redundant environment flags on > read. > > flag0 and flag1 in fw_env_open() were declared signed instead of > unsigned char breaking BOOLEAN mode "== 0xFF"

[U-Boot] [PATCH] tools/env: fix redundant env flag comparison

2011-03-10 Thread Jon Povey
This fixes two bugs with comparison of redundant environment flags on read. flag0 and flag1 in fw_env_open() were declared signed instead of unsigned char breaking BOOLEAN mode "== 0xFF" tests and in INCREMENTAL mode the wrong environment would be chosen where the flag values are 127 and 128 (eith